Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetBase.cpp

Issue 2844243003: Speculative fix for crash in blink::DragData::modifiers. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebFrameWidgetBase.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp b/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp
index d6f1367719f4c65046900512c707bccd2010a79b..a5a1d8c5448e3664b158ba65599bd3b64ebd5757 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp
+++ b/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp
@@ -80,7 +80,12 @@ void WebFrameWidgetBase::DragTargetDragLeave(const WebPoint& point_in_viewport,
const WebPoint& screen_point) {
DCHECK(current_drag_data_);
- if (IgnoreInputEvents()) {
+ // TODO(paulmeyer): It shouldn't be possible for |m_currentDragData| to be
+ // null here, but this is somehow happening (rarely). This suggests that in
+ // some cases drag-leave is happening before drag-enter, which should be
+ // impossible. This needs to be investigated further. Once fixed, the extra
+ // check for |!m_currentDragData| should be removed. (crbug.com/671152)
+ if (IgnoreInputEvents() || !current_drag_data_) {
CancelDrag();
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698