Mojo C++ bindings: reject messages version 2 with null payload pointer.

Mojo C++ bindings: reject messages version 2 with null payload pointer.

BUG=712416
Review-Url: https://codereview.chromium.org/2844143002
Cr-Commit-Position: refs/heads/master@{#468211}
Committed: https://chromium.googlesource.com/chromium/src/+/876a00f954e8fda36c14bde228d95c4ac885647b

[yzshen1, 2017-04-26 23:42:23]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 23:43:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-04-26 23:47:10]

yzshen@chromium.org changed reviewers:
+ rockot@chromium.org

[yzshen1, 2017-04-26 23:47:11]

Hi, Ken.

Would you please take a look? Thanks!

I am now less certain about whether it is a good idea to have this payload
pointer in the message header V2. It makes the entire message become a struct;
but it also adds this validation/serialization cost that is mostly useless....

[commit-bot: I haz the power, 2017-04-27 00:01:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 00:01:02]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Rockot(use gerrit already), 2017-04-27 14:56:31]

lgtm

[yzshen1, 2017-04-27 15:47:03]

yzshen@chromium.org changed reviewers:
+ tsepez@chromium.org

[yzshen1, 2017-04-27 15:47:03]

Hi, Tom.

Would you please take a look at the mojom file change. That is a testing
interface.

Thanks!

[Tom Sepez, 2017-04-27 16:10:36]

lgtm

https://codereview.chromium.org/2844143002/diff/1/mojo/edk/js/tests/js_to_cpp...
File mojo/edk/js/tests/js_to_cpp.mojom (right):

https://codereview.chromium.org/2844143002/diff/1/mojo/edk/js/tests/js_to_cpp...
mojo/edk/js/tests/js_to_cpp.mojom:31: interface NotUsed {};
nit: maybe call it AssociatedForTesting, as it is used, just only for testing
...

[yzshen1, 2017-04-27 17:15:33]

Hi, Tom.

FYI, I also added a OWNERS file to allow this testing mojom reviewed by any mojo
owners, instead of requiring security review.

(The same thing has been done for other testing interfaces in
mojo/public/interfaces/bindings/tests.)

https://codereview.chromium.org/2844143002/diff/1/mojo/edk/js/tests/js_to_cpp...
File mojo/edk/js/tests/js_to_cpp.mojom (right):

https://codereview.chromium.org/2844143002/diff/1/mojo/edk/js/tests/js_to_cpp...
mojo/edk/js/tests/js_to_cpp.mojom:31: interface NotUsed {};
On 2017/04/27 16:10:36, Tom Sepez wrote:
> nit: maybe call it AssociatedForTesting, as it is used, just only for testing
> ...

Good point, done.

[yzshen1, 2017-04-27 17:15:40]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 17:16:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 17:39:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 17:39:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yzshen1, 2017-04-29 00:59:17]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2017-04-29 00:59:18]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2844143002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2017-04-29 00:59:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 02:11:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493427557780310,
"parent_rev": "9c04ed553bd7abe820a6a93c5e8981e6738881a9", "commit_rev":
"876a00f954e8fda36c14bde228d95c4ac885647b"}

[commit-bot: I haz the power, 2017-04-29 02:11:54]

Description was changed from

==========
Mojo C++ bindings: reject messages version 2 with null payload pointer.

BUG=712416
==========

to

==========
Mojo C++ bindings: reject messages version 2 with null payload pointer.

BUG=712416

Review-Url: https://codereview.chromium.org/2844143002
Cr-Commit-Position: refs/heads/master@{#468211}
Committed:
https://chromium.googlesource.com/chromium/src/+/876a00f954e8fda36c14bde228d9...
==========

[commit-bot: I haz the power, 2017-04-29 02:12:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/876a00f954e8fda36c14bde228d9...