Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: mojo/edk/js/tests/js_to_cpp.mojom

Issue 2844143002: Mojo C++ bindings: reject messages version 2 with null payload pointer. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/js/tests/OWNERS ('k') | mojo/edk/js/tests/js_to_cpp_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/js/tests/js_to_cpp.mojom
diff --git a/mojo/edk/js/tests/js_to_cpp.mojom b/mojo/edk/js/tests/js_to_cpp.mojom
index 688b22b3dea8321a9d402535f5983bebae8b2cb5..3e4bd1a26282ac9129d3769763a29ab8f9546f6c 100644
--- a/mojo/edk/js/tests/js_to_cpp.mojom
+++ b/mojo/edk/js/tests/js_to_cpp.mojom
@@ -28,6 +28,8 @@ struct EchoArgsList {
EchoArgs? item;
};
+interface ForTesting {};
+
// Note: For messages which control test flow, pick numbers that are unlikely
// to be hit as a result of our deliberate corruption of response messages.
interface CppSide {
@@ -40,7 +42,11 @@ interface CppSide {
// Responses from specific tests.
PingResponse();
EchoResponse(EchoArgsList list);
- BitFlipResponse(EchoArgsList arg);
+
+ // Having an associated interface pointer in the message makes sure the
+ // message header version 2 is tested.
+ BitFlipResponse(EchoArgsList arg, associated ForTesting? not_used);
+
BackPointerResponse(EchoArgsList arg);
};
« no previous file with comments | « mojo/edk/js/tests/OWNERS ('k') | mojo/edk/js/tests/js_to_cpp_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698