Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2844133002: Support tracing metrics for measureTime & measureFrameTime methods in blink_perf (Reland) (Closed)

Created:
3 years, 8 months ago by nednguyen
Modified:
3 years, 7 months ago
CC:
chromium-reviews, blink-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Support tracing metrics for measureTime & measureFrameTime methods in blink_perf (Reland) * Fix include: 1) handle cases thread_times = None 2) disable testBlinkPerfTracingMetricsForMeasureTime on Win This CL adds support for tracing metrics with measureTime & measureFrameTime methods in blink_perf harness. If a test has "tracingCategories" & "traceEventsToMeasure" fields specified, Telemetry will enable the specified tracing categories & compute the cpu time of all the specified trace events (one per test run). Detailed examples of how to use this new API are in third_party/WebKit/PerformanceTests/TestData/ BUG=701059, 715822 TBR=wangxianzhu@chromium.org Reviewer: you can see this in action by patching this CL & run: ./tools/perf/run_benchmark --browser=system blink_perf.testing --story-filter=frame --output-format=json [ RUN ] append-child-measure-time.html ... ... CPU times of trace event "UpdateLayoutTree": values 1.8760000000, 3.2080000000, 3.4260000000, 1.9020000000, 1.6990000000, 2.2940000000, 1.8570000000, 1.7100000000, 1.4170000000, 1.4150000000 ms avg 2.0804000000 ms CPU times of trace event "FrameView::layout": values 4.6150000000, 8.3140000000, 8.6080000000, 4.4360000000, 4.0940000000, 5.9130000000, 4.5970000000, 3.9440000000, 3.4590000000, 3.4600000000 ms avg 5.1440000000 ms [ RUN ] color-changes-measure-frame-time.html ... ... CPU times of trace event "FrameView::prePaint": values 5.9890000000, 5.9640000000, 6.2360000000, 6.3870000000, 5.9490000000, 6.3450000000, 6.3340000000, 6.9270000000, 6.8910000000 ms avg 6.3357777778 ms CPU times of trace event "FrameView::paintTree": values 30.0950000000, 30.5020000000, 30.6510000000, 30.3380000000, 30.4160000000, 30.3480000000, 30.5110000000, 30.7570000000, 30.6140000000 ms avg 30.4702222222 ms After running the command above, the command also produces 2 trace files locally, one for each test. Review-Url: https://codereview.chromium.org/2819343002 Cr-Commit-Position: refs/heads/master@{#467445} Committed: https://chromium.googlesource.com/chromium/src/+/0d2d43615b4553f00ac711f54dbcc0835f04366b patch from issue 2819343002 at patchset 270001 (http://crrev.com/2819343002#ps270001) Review-Url: https://codereview.chromium.org/2844133002 Cr-Commit-Position: refs/heads/master@{#467637} Committed: https://chromium.googlesource.com/chromium/src/+/c5cc2a4f4e1ae4dfd1459cba00e7d7a217bc1f70

Patch Set 1 #

Patch Set 2 : Fix thread times & disable tests on Win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+469 lines, -4 lines) Patch
A third_party/WebKit/PerformanceTests/TestData/append-child-measure-time.html View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html View 1 chunk +84 lines, -0 lines 0 comments Download
M third_party/WebKit/PerformanceTests/resources/runner.js View 5 chunks +44 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/blink_perf.js View 1 chunk +18 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 1 4 chunks +104 lines, -1 line 0 comments Download
A tools/perf/benchmarks/blink_perf_unittest.py View 1 1 chunk +183 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844133002/20001
3 years, 8 months ago (2017-04-26 23:33:00 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/440066)
3 years, 8 months ago (2017-04-27 02:03:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844133002/20001
3 years, 7 months ago (2017-04-27 10:23:26 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 11:26:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c5cc2a4f4e1ae4dfd1459cba00e7...

Powered by Google App Engine
This is Rietveld 408576698