Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Issue 2844053003: Revert of [tickprocessor] Consider top of the stack as pc if it points to a code object. (Closed)

Created:
3 years, 7 months ago by Benedikt Meurer
Modified:
3 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [tickprocessor] Consider top of the stack as pc if it points to a code object. (patchset #1 id:1 of https://codereview.chromium.org/2822433002/ ) Reason for revert: Seems to lead to more (completely) misattributed ticks Original issue's description: > [tickprocessor] Consider top of the stack as pc if it points to a code object. > > Previously, we would only consider it if it pointed to a full-code JS function. > Thus we could miss both optimized functions and bytecode handlers if they > called frame-less code. > > Review-Url: https://codereview.chromium.org/2822433002 > Cr-Commit-Position: refs/heads/master@{#44640} > Committed: https://chromium.googlesource.com/v8/v8/+/4433ac299eae30b75357b05dab16d142d239f64e TBR=jarin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2844053003 Cr-Commit-Position: refs/heads/master@{#44921} Committed: https://chromium.googlesource.com/v8/v8/+/216e677a0ca7728fb44b5b77ec39d6baa3ec05dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/tickprocessor.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Benedikt Meurer
Created Revert of [tickprocessor] Consider top of the stack as pc if it points to ...
3 years, 7 months ago (2017-04-27 09:38:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844053003/1
3 years, 7 months ago (2017-04-27 09:38:20 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 10:07:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/216e677a0ca7728fb44b5b77ec39d6baa3e...

Powered by Google App Engine
This is Rietveld 408576698