[tickprocessor] Consider top of the stack as pc if it points to a code object.

[tickprocessor] Consider top of the stack as pc if it points to a code object.

Previously, we would only consider it if it pointed to a full-code JS function.
Thus we could miss both optimized functions and bytecode handlers if they
called frame-less code.

Review-Url: https://codereview.chromium.org/2822433002
Cr-Commit-Position: refs/heads/master@{#44640}
Committed: https://chromium.googlesource.com/v8/v8/+/4433ac299eae30b75357b05dab16d142d239f64e

[Jarin, 2017-04-13 10:50:28]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 10:50:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2017-04-13 10:52:15]

jarin@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Jarin, 2017-04-13 10:52:16]

This is the profiler call stack you already using :-)

[Benedikt Meurer, 2017-04-13 10:59:39]

lgtm

[Jarin, 2017-04-13 11:07:10]

The CQ bit was unchecked by jarin@chromium.org

[Jarin, 2017-04-13 11:07:11]

The CQ bit was checked by jarin@chromium.org

[commit-bot: I haz the power, 2017-04-13 11:07:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 11:13:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492081631273790, "parent_rev":
"f09460389ba5f0990b11e245804d0b6151a5c52b", "commit_rev":
"4433ac299eae30b75357b05dab16d142d239f64e"}

[commit-bot: I haz the power, 2017-04-13 11:13:36]

Description was changed from

==========
[tickprocessor] Consider top of the stack as pc if it points to a code object.

Previously, we would only consider it if it pointed to a full-code JS function.
Thus we could miss both optimized functions and bytecode handlers if they
called frame-less code.
==========

to

==========
[tickprocessor] Consider top of the stack as pc if it points to a code object.

Previously, we would only consider it if it pointed to a full-code JS function.
Thus we could miss both optimized functions and bytecode handlers if they
called frame-less code.

Review-Url: https://codereview.chromium.org/2822433002
Cr-Commit-Position: refs/heads/master@{#44640}
Committed:
https://chromium.googlesource.com/v8/v8/+/4433ac299eae30b75357b05dab16d142d23...
==========

[commit-bot: I haz the power, 2017-04-13 11:13:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4433ac299eae30b75357b05dab16d142d23...

[Benedikt Meurer, 2017-04-27 09:38:14]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2844053003/ by bmeurer@chromium.org.

The reason for reverting is: Seems to lead to more (completely) misattributed
ticks.