chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java - Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)

Patch Set: address comments from treib@ Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

index db5f2293b00fd6464e46bf150626871e59550be1..8738ba3629c402e6aca621a29930707418a30195 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

@@ -61,7 +61,7 @@ public int getPerSectionRank() {

@VisibleForTesting

void performAction(SuggestionsUiDelegate uiDelegate) {

- uiDelegate.getMetricsReporter().onMoreButtonClicked(this);

+ uiDelegate.getEventReporter().onMoreButtonClicked(this);

switch (mCategoryInfo.getAdditionalAction()) {

case ContentSuggestionsAdditionalAction.VIEW_ALL:

@@ -101,7 +101,7 @@ public void onClick(View v) {

public void onImpression() {

if (mActionListItem != null && !mActionListItem.mImpressionTracked) {

mActionListItem.mImpressionTracked = true;

- uiDelegate.getMetricsReporter().onMoreButtonShown(mActionListItem);

+ uiDelegate.getEventReporter().onMoreButtonShown(mActionListItem);

}

});