chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java - Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)

Patch Set: address comments from treib@ Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java

index d6c08f6b24a7793441f6e904024c05e3a27e1044..5b48f40ca669869fec4968c2da9eb0e7c3570726 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java

@@ -12,8 +12,8 @@

import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.IntentHandler;

import org.chromium.chrome.browser.UrlConstants;

-import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge;

import org.chromium.chrome.browser.rappor.RapporServiceBridge;

+import org.chromium.chrome.browser.suggestions.SuggestionsEventReporterBridge;

import org.chromium.chrome.browser.tab.EmptyTabObserver;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tabmodel.EmptyTabModelSelectorObserver;

@@ -384,7 +384,7 @@ private void endRecording(Tab removeObserverFromTab) {

if (removeObserverFromTab != null) removeObserverFromTab.removeObserver(this);

RecordUserAction.record("MobileNTP.Snippets.VisitEnd");

long visitTimeMs = SystemClock.elapsedRealtime() - mStartTimeMs;

- SnippetsBridge.onSuggestionTargetVisited(mCategory, visitTimeMs);

+ SuggestionsEventReporterBridge.onSuggestionTargetVisited(mCategory, visitTimeMs);

}