Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3492)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)
Patch Set: address comments from treib@ Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
index b70c0ed6cce9b7be334c7424fcbb09da9c1ce199..15d7a619f976e8816b77a6f0c271cbf4f3c3ea48 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
@@ -33,13 +33,10 @@
private final Map<Integer, SuggestionsSection> mSections = new LinkedHashMap<>();
private final SuggestionsUiDelegate mUiDelegate;
private final OfflinePageBridge mOfflinePageBridge;
- private final SuggestionsRanker mSuggestionsRanker;
public SectionList(SuggestionsUiDelegate uiDelegate, OfflinePageBridge offlinePageBridge) {
- mSuggestionsRanker = new SuggestionsRanker();
mUiDelegate = uiDelegate;
mUiDelegate.getSuggestionsSource().setObserver(this);
- mUiDelegate.getMetricsReporter().setRanker(mSuggestionsRanker);
mOfflinePageBridge = offlinePageBridge;
mUiDelegate.addDestructionObserver(new DestructionObserver() {
@@ -76,7 +73,7 @@ private void resetSections(boolean alwaysAllowEmptySections) {
}
maybeHideArticlesHeader();
- mUiDelegate.getMetricsReporter().onPageShown(categories, suggestionsPerCategory);
+ mUiDelegate.getEventReporter().onPageShown(categories, suggestionsPerCategory);
}
/**
@@ -105,10 +102,11 @@ private int resetSection(@CategoryInt int category, @CategoryStatus int category
// Create the section if needed.
if (section == null) {
+ SuggestionsRanker suggestionsRanker = mUiDelegate.getSuggestionsRanker();
section = new SuggestionsSection(
- this, mUiDelegate, mSuggestionsRanker, mOfflinePageBridge, info);
+ this, mUiDelegate, suggestionsRanker, mOfflinePageBridge, info);
mSections.put(category, section);
- mSuggestionsRanker.registerCategory(category);
+ suggestionsRanker.registerCategory(category);
addChild(section);
}

Powered by Google App Engine
This is Rietveld 408576698