Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: chrome/android/java/res/layout/photo_picker_bitmap_view.xml

Issue 2843973002: Use larger vector graphics for special tiles and fix selection ring. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/photo_picker_bitmap_view.xml
diff --git a/chrome/android/java/res/layout/photo_picker_bitmap_view.xml b/chrome/android/java/res/layout/photo_picker_bitmap_view.xml
index 01718226172e79a6f466476dfbc2bca3bfa3b850..181a334188134272f4bb7d60c8367e817a0c246f 100644
--- a/chrome/android/java/res/layout/photo_picker_bitmap_view.xml
+++ b/chrome/android/java/res/layout/photo_picker_bitmap_view.xml
@@ -32,14 +32,13 @@
android:visibility="gone" />
</FrameLayout>
- <ImageView
+ <View
android:id="@+id/selected"
- android:layout_width="24dp"
- android:layout_height="24dp"
- android:layout_marginStart="4dp"
- android:layout_marginTop="4dp"
- android:contentDescription="@null"
- android:src="@drawable/verify_checkmark"
+ android:layout_width="26dp"
+ android:layout_height="26dp"
+ android:layout_marginStart="2dp"
+ android:layout_marginTop="2dp"
+ android:background="@drawable/checkmark_blue"
Theresa 2017/04/26 18:04:31 We don't gain any APK size savings since the verif
Finnur 2017/04/26 20:30:44 The impetus for this change is not efficiency. The
Theresa 2017/04/26 20:47:17 I didn't realize that the spec had a blue check w/
Finnur 2017/04/27 15:02:26 I'll probably have an answer when I see your feedb
android:visibility="gone" />
<View

Powered by Google App Engine
This is Rietveld 408576698