Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: chrome/android/java/res/layout/photo_picker_bitmap_view.xml

Issue 2843973002: Use larger vector graphics for special tiles and fix selection ring. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- 2 <!--
3 Copyright 2017 The Chromium Authors. All rights reserved. 3 Copyright 2017 The Chromium Authors. All rights reserved.
4 Use of this source code is governed by a BSD-style license that can be 4 Use of this source code is governed by a BSD-style license that can be
5 found in the LICENSE file. 5 found in the LICENSE file.
6 --> 6 -->
7 7
8 <!-- Represents a single item in the Photo Picker. --> 8 <!-- Represents a single item in the Photo Picker. -->
9 9
10 <view class="org.chromium.chrome.browser.photo_picker.PickerBitmapView" 10 <view class="org.chromium.chrome.browser.photo_picker.PickerBitmapView"
(...skipping 14 matching lines...) Expand all
25 android:contentDescription="@null" /> 25 android:contentDescription="@null" />
26 26
27 <View 27 <View
28 android:id="@+id/scrim" 28 android:id="@+id/scrim"
29 android:layout_width="64dp" 29 android:layout_width="64dp"
30 android:layout_height="64dp" 30 android:layout_height="64dp"
31 android:background="@drawable/file_picker_scrim" 31 android:background="@drawable/file_picker_scrim"
32 android:visibility="gone" /> 32 android:visibility="gone" />
33 </FrameLayout> 33 </FrameLayout>
34 34
35 <ImageView 35 <View
36 android:id="@+id/selected" 36 android:id="@+id/selected"
37 android:layout_width="24dp" 37 android:layout_width="26dp"
38 android:layout_height="24dp" 38 android:layout_height="26dp"
39 android:layout_marginStart="4dp" 39 android:layout_marginStart="2dp"
40 android:layout_marginTop="4dp" 40 android:layout_marginTop="2dp"
41 android:contentDescription="@null" 41 android:background="@drawable/checkmark_blue"
Theresa 2017/04/26 18:04:31 We don't gain any APK size savings since the verif
Finnur 2017/04/26 20:30:44 The impetus for this change is not efficiency. The
Theresa 2017/04/26 20:47:17 I didn't realize that the spec had a blue check w/
Finnur 2017/04/27 15:02:26 I'll probably have an answer when I see your feedb
42 android:src="@drawable/verify_checkmark"
43 android:visibility="gone" /> 42 android:visibility="gone" />
44 43
45 <View 44 <View
46 android:id="@+id/unselected" 45 android:id="@+id/unselected"
47 android:layout_width="22dp" 46 android:layout_width="22dp"
48 android:layout_height="22dp" 47 android:layout_height="22dp"
49 android:layout_marginStart="4dp" 48 android:layout_marginStart="4dp"
50 android:layout_marginTop="4dp" 49 android:layout_marginTop="4dp"
51 android:background="@drawable/circle_white" 50 android:background="@drawable/circle_white"
52 android:visibility="gone" /> 51 android:visibility="gone" />
53 52
54 <!-- Special tiles, that give access to the camera and gallery --> 53 <!-- Special tiles, that give access to the camera and gallery -->
55 <TextView 54 <TextView
56 android:id="@+id/special_tile" 55 android:id="@+id/special_tile"
57 android:layout_width="match_parent" 56 android:layout_width="match_parent"
58 android:layout_height="wrap_content" 57 android:layout_height="wrap_content"
59 android:layout_marginTop="@dimen/photo_picker_label_gap" 58 android:layout_marginTop="@dimen/photo_picker_label_gap"
60 android:drawablePadding="10dp" 59 android:drawablePadding="10dp"
61 android:fontFamily="sans-serif-medium" 60 android:fontFamily="sans-serif-medium"
62 android:textStyle="bold" 61 android:textStyle="bold"
63 android:textSize="14sp" 62 android:textSize="14sp"
64 android:textAllCaps="true" 63 android:textAllCaps="true"
65 android:textColor="@color/photo_picker_special_tile_color" 64 android:textColor="@color/photo_picker_special_tile_color"
66 android:gravity="center" 65 android:gravity="center"
67 android:layout_gravity="center" /> 66 android:layout_gravity="center" />
68 </view> 67 </view>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698