Use larger vector graphics for special tiles and fix selection ring.

chrome/android/java/res/drawable/ic_collections_grey600_48dp.xml

Index: chrome/android/java/res/drawable/ic_collections_grey600_48dp.xml
diff --git a/chrome/android/java/res/drawable/ic_collections_grey600_48dp.xml b/chrome/android/java/res/drawable/ic_collections_grey600_48dp.xml
new file mode 100644
index 0000000000000000000000000000000000000000..aa1223d71c6ee53720dfaa09bdb3efac71d563db
--- /dev/null
+++ b/chrome/android/java/res/drawable/ic_collections_grey600_48dp.xml
@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2017 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+

[Theresa, 2017/04/26 18:04:31]

We already have an ic_collections_grey.xml that's grey_google_grey_600. Can we
share?

[Finnur, 2017/04/26 20:30:44]

The impetus for this change is larger icons for the special tiles. Really dumb
question: Is this as simple as using ic_collections_grey.xml and doubling the
size specified in xml? If I were at my desk I'd try, but I'm not (and I'd like
to get one round of discussion in before your EOD). :)

[Theresa, 2017/04/26 20:47:17]

You should be able to display ic_collections_grey.xml in an Image View height &
width = 48dp and scaleType = center (or maybe center_crop).

[Finnur, 2017/04/27 15:02:26]

When I did this initially, I used an ImageView (for the Collections icon) and a
TextView (for the Gallery label). This errored out in a pre-submit script with a
note saying I should use a TextView with an image drawable instead.

Can you advise how I can satisfy both the review comment (use an ImageView) and
the pre-submit script (use a TextView)?

For fun, I tried sizing the TextView, but that just increases the size of the
view and doesn't scale up the drawable.

[Theresa, 2017/04/27 15:45:27]

Try calling setBounds() on the vector drawable.

If that doesn't work, then change ic_collections_grey.xml and check that the
other use looks correct. The one other use is in settings. I *think* the
ImageView probably already has properties set to scale correctly, but if not we
can try setting properties on the ImageView directly or bounds on that drawable.

If we can't get it to work, I'll acquiesce, but the whole point of vectors is
crisp scaling so it seems like a shame to have different XML files for different
sizes.

[Theresa, 2017/04/27 15:49:49]

Also, what was the exact error. We may be able to suppress it and add a comment
explaining the suppression.

+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
+    tools:targetApi="21"
+    android:width="48dp"
+    android:height="48dp"
+    android:viewportWidth="48"
+    android:viewportHeight="48">
+
+    <path
+        android:pathData="M0 0h48v48H0z" />
+    <path
+        android:fillColor="@color/google_grey_600"
+        android:pathData="M44 32V8c0-2.21-1.79-4-4-4H16c-2.21 0-4 1.79-4 4v24c0 2.21 1.79 4 4 4h24c2.21 0
+4-1.79 4-4zm-22-8l4.06 5.42L32 22l8 10H16l6-8zM4 12v28c0 2.21 1.79 4 4
+4h28v-4H8V12H4z" />
+</vector>