chrome/android/java/res/drawable/ic_collections_grey600_48dp.xml - Issue 2843973002: Use larger vector graphics for special tiles and fix selection ring.

Side by Side Diff: chrome/android/java/res/drawable/ic_collections_grey600_48dp.xml

Issue 2843973002: Use larger vector graphics for special tiles and fix selection ring. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « chrome/android/java/res/drawable/circle_white.xml ('k') | chrome/android/java/res/drawable/ic_photo_camera600_48dp.xml » ('j') | chrome/android/java/res/layout/photo_picker_bitmap_view.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5
	Theresa 2017/04/26 18:04:31 We already have an ic_collections_grey.xml that's We already have an ic_collections_grey.xml that's grey_google_grey_600. Can we share? Finnur 2017/04/26 20:30:44 The impetus for this change is larger icons for th The impetus for this change is larger icons for the special tiles. Really dumb question: Is this as simple as using ic_collections_grey.xml and doubling the size specified in xml? If I were at my desk I'd try, but I'm not (and I'd like to get one round of discussion in before your EOD). :) Theresa 2017/04/26 20:47:17 You should be able to display ic_collections_grey. Show quoted text On 2017/04/26 20:30:44, Finnur wrote: > The impetus for this change is larger icons for the special tiles. Really dumb > question: Is this as simple as using ic_collections_grey.xml and doubling the > size specified in xml? If I were at my desk I'd try, but I'm not (and I'd like > to get one round of discussion in before your EOD). :) You should be able to display ic_collections_grey.xml in an Image View height & width = 48dp and scaleType = center (or maybe center_crop). Finnur 2017/04/27 15:02:26 When I did this initially, I used an ImageView (fo When I did this initially, I used an ImageView (for the Collections icon) and a TextView (for the Gallery label). This errored out in a pre-submit script with a note saying I should use a TextView with an image drawable instead. Can you advise how I can satisfy both the review comment (use an ImageView) and the pre-submit script (use a TextView)? For fun, I tried sizing the TextView, but that just increases the size of the view and doesn't scale up the drawable. Theresa 2017/04/27 15:45:27 Try calling setBounds() on the vector drawable. I Show quoted text On 2017/04/27 15:02:26, Finnur wrote: > When I did this initially, I used an ImageView (for the Collections icon) and a > TextView (for the Gallery label). This errored out in a pre-submit script with a > note saying I should use a TextView with an image drawable instead. > > Can you advise how I can satisfy both the review comment (use an ImageView) and > the pre-submit script (use a TextView)? > > For fun, I tried sizing the TextView, but that just increases the size of the > view and doesn't scale up the drawable. Try calling setBounds() on the vector drawable. If that doesn't work, then change ic_collections_grey.xml and check that the other use looks correct. The one other use is in settings. I think the ImageView probably already has properties set to scale correctly, but if not we can try setting properties on the ImageView directly or bounds on that drawable. If we can't get it to work, I'll acquiesce, but the whole point of vectors is crisp scaling so it seems like a shame to have different XML files for different sizes. Theresa 2017/04/27 15:49:49 Also, what was the exact error. We may be able to Show quoted text On 2017/04/27 15:45:27, Theresa wrote: > On 2017/04/27 15:02:26, Finnur wrote: > > When I did this initially, I used an ImageView (for the Collections icon) and > a > > TextView (for the Gallery label). This errored out in a pre-submit script with > a > > note saying I should use a TextView with an image drawable instead. > > > > Can you advise how I can satisfy both the review comment (use an ImageView) > and > > the pre-submit script (use a TextView)? > > > > For fun, I tried sizing the TextView, but that just increases the size of the > > view and doesn't scale up the drawable. > > Try calling setBounds() on the vector drawable. > > If that doesn't work, then change ic_collections_grey.xml and check that the > other use looks correct. The one other use is in settings. I think the > ImageView probably already has properties set to scale correctly, but if not we > can try setting properties on the ImageView directly or bounds on that drawable. > > If we can't get it to work, I'll acquiesce, but the whole point of vectors is > crisp scaling so it seems like a shame to have different XML files for different > sizes. Also, what was the exact error. We may be able to suppress it and add a comment explaining the suppression.
	6 <vector xmlns:android="http://schemas.android.com/apk/res/android"

	7 xmlns:tools="http://schemas.android.com/tools"

	8 tools:targetApi="21"

	9 android:width="48dp"

	10 android:height="48dp"

	11 android:viewportWidth="48"

	12 android:viewportHeight="48">

	13

	14 <path

	15 android:pathData="M0 0h48v48H0z" />

	16 <path

	17 android:fillColor="@color/google_grey_600"

	18 android:pathData="M44 32V8c0-2.21-1.79-4-4-4H16c-2.21 0-4 1.79-4 4v24c0 2.21 1.79 4 4 4h24c2.21 0

	19 4-1.79 4-4zm-22-8l4.06 5.42L32 22l8 10H16l6-8zM4 12v28c0 2.21 1.79 4 4

	20 4h28v-4H8V12H4z" />

	21 </vector>

OLD	NEW