DescriptionRevert of Get rid of computeVisibleSelectionInDOMTreeDeprecated() in InputMethodController (patchset #5 id:80001 of https://codereview.chromium.org/2782413002/ )
Reason for revert:
This caused large memory regressions. See http://crbug.com/711366 for details.
BUG=711366
Original issue's description:
> Get rid of computeVisibleSelectionInDOMTreeDeprecated() in InputMethodController::textInputType() and textInputInfo()
>
> This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by replacing
> it with |rootEditableElementOf()| with non-canonicalize position from
> |textInputInfo()| and |textInputType()| of |InputMethodController| for improving
> code health.
>
> Node: Because of selection can't cross editing boundary, root editable element for
> non-canonicalized position and canonicalized position are same.
>
> This patch is intentionally not change all call sites of |rootEditableElement()|
> in |InputMethodController| to merge this patch as workaround of [1].
>
> [1] http://crbug.com/704763 Opacity animation consuming main thread resources
>
> BUG=698633, 704763
> TEST=n/a; no behavior changes
>
> Review-Url: https://codereview.chromium.org/2782413002
> Cr-Original-Commit-Position: refs/heads/master@{#460705}
> Committed: https://chromium.googlesource.com/chromium/src/+/9744d5bffb3fbdf761455b355ebc4faa757d1aaf
> Review-Url: https://codereview.chromium.org/2782413002
> Cr-Commit-Position: refs/heads/master@{#463575}
> Committed: https://chromium.googlesource.com/chromium/src/+/e14aacd2baf5cf9c4a5e457384e0b0f73c0163c4
TBR=tkent@chromium.org,xiaochengh@chromium.org,yoichio@chromium.org,yosin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=698633, 704763
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|