Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2843943002: Revert of Get rid of computeVisibleSelectionInDOMTreeDeprecated() in InputMethodController (Closed)

Created:
3 years, 8 months ago by sullivan
Modified:
3 years, 7 months ago
CC:
alancutter (OOO until 2018), blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Get rid of computeVisibleSelectionInDOMTreeDeprecated() in InputMethodController (patchset #5 id:80001 of https://codereview.chromium.org/2782413002/ ) Reason for revert: This caused large memory regressions. See http://crbug.com/711366 for details. BUG=711366 Original issue's description: > Get rid of computeVisibleSelectionInDOMTreeDeprecated() in InputMethodController::textInputType() and textInputInfo() > > This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by replacing > it with |rootEditableElementOf()| with non-canonicalize position from > |textInputInfo()| and |textInputType()| of |InputMethodController| for improving > code health. > > Node: Because of selection can't cross editing boundary, root editable element for > non-canonicalized position and canonicalized position are same. > > This patch is intentionally not change all call sites of |rootEditableElement()| > in |InputMethodController| to merge this patch as workaround of [1]. > > [1] http://crbug.com/704763 Opacity animation consuming main thread resources > > BUG=698633, 704763 > TEST=n/a; no behavior changes > > Review-Url: https://codereview.chromium.org/2782413002 > Cr-Original-Commit-Position: refs/heads/master@{#460705} > Committed: https://chromium.googlesource.com/chromium/src/+/9744d5bffb3fbdf761455b355ebc4faa757d1aaf > Review-Url: https://codereview.chromium.org/2782413002 > Cr-Commit-Position: refs/heads/master@{#463575} > Committed: https://chromium.googlesource.com/chromium/src/+/e14aacd2baf5cf9c4a5e457384e0b0f73c0163c4 TBR=tkent@chromium.org,xiaochengh@chromium.org,yoichio@chromium.org,yosin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=698633, 704763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sullivan
Created Revert of Get rid of computeVisibleSelectionInDOMTreeDeprecated() in InputMethodController
3 years, 8 months ago (2017-04-26 13:09:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843943002/1
3 years, 8 months ago (2017-04-26 13:09:57 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/370571)
3 years, 8 months ago (2017-04-26 13:12:44 UTC) #5
yosin_UTC9
3 years, 7 months ago (2017-04-27 04:34:42 UTC) #6
I created patch[1] for identical of this revert patch.

[1] http://crrev.com/2849453002: Add redundant update layout in
InputMethodController to solve memory regresssion

Powered by Google App Engine
This is Rietveld 408576698