Get rid of computeVisibleSelectionInDOMTreeDeprecated() in InputMethodController

Get rid of computeVisibleSelectionInDOMTreeDeprecated() in InputMethodController::textInputType() and textInputInfo()

This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by replacing
it with |rootEditableElementOf()| with non-canonicalize position from
|textInputInfo()| and |textInputType()| of |InputMethodController| for improving
code health.

Node: Because of selection can't cross editing boundary, root editable element for
non-canonicalized position and canonicalized position are same.

This patch is intentionally not change all call sites of |rootEditableElement()|
in |InputMethodController| to merge this patch as workaround of [1].

[1] http://crbug.com/704763 Opacity animation consuming main thread resources

BUG=698633, 704763
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2782413002
Cr-Original-Commit-Position: refs/heads/master@{#460705}
Committed: https://chromium.googlesource.com/chromium/src/+/9744d5bffb3fbdf761455b355ebc4faa757d1aaf
Review-Url: https://codereview.chromium.org/2782413002
Cr-Commit-Position: refs/heads/master@{#463575}
Committed: https://chromium.googlesource.com/chromium/src/+/e14aacd2baf5cf9c4a5e457384e0b0f73c0163c4

[yosin_UTC9, 2017-03-30 05:29:12]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 05:29:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-30 05:37:55]

Description was changed from

==========
2017-03-30T14:27:13

2017-03-30T14:26:12

BUG=
==========

to

==========
Get rid of computeVisibleSelectionInDOMTreeDeprecated() in
InputMethodController::textInputType()

This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by
replacing
it with |rootEditableElementOf()| with non-canonicalize position for improving
code health.

Node: Because of selection can't cross editing boundary, root editable element
for
non-canonicalized position and canonicalized position are same.

BUG=698633
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-30 05:53:47]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 05:54:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alancutter (OOO until 2018), 2017-03-30 06:27:16]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 06:27:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-30 06:28:28]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 06:28:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-30 06:42:41]

Description was changed from

==========
Get rid of computeVisibleSelectionInDOMTreeDeprecated() in
InputMethodController::textInputType()

This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by
replacing
it with |rootEditableElementOf()| with non-canonicalize position for improving
code health.

Node: Because of selection can't cross editing boundary, root editable element
for
non-canonicalized position and canonicalized position are same.

BUG=698633
TEST=n/a; no behavior changes
==========

to

==========
Get rid of computeVisibleSelectionInDOMTreeDeprecated() in
InputMethodController::textInputType()

This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by
replacing
it with |rootEditableElementOf()| with non-canonicalize position for improving
code health.

Node: Because of selection can't cross editing boundary, root editable element
for
non-canonicalized position and canonicalized position are same.

This patch also helps issue 704763 by reducing update layout call.

BUG=698633, 704763
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-30 06:42:41]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org
- alancutter@chromium.org

[yosin_UTC9, 2017-03-30 06:47:41]

Description was changed from

==========
Get rid of computeVisibleSelectionInDOMTreeDeprecated() in
InputMethodController::textInputType()

This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by
replacing
it with |rootEditableElementOf()| with non-canonicalize position for improving
code health.

Node: Because of selection can't cross editing boundary, root editable element
for
non-canonicalized position and canonicalized position are same.

This patch also helps issue 704763 by reducing update layout call.

BUG=698633, 704763
TEST=n/a; no behavior changes
==========

to

==========
Get rid of computeVisibleSelectionInDOMTreeDeprecated() in
InputMethodController::textInputType() and textInputInfo()

This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by
replacing
it with |rootEditableElementOf()| with non-canonicalize position from
|textInputInfo()| and |textInputType()| of |InputMethodController| for improving
code health.

Node: Because of selection can't cross editing boundary, root editable element
for
non-canonicalized position and canonicalized position are same.

To make this patch small for merging of workaround of [1], following patch will
replace other use of VisibleSelection::rootEditableElement().

[1] http://crbug.com/704763 Opacity animation consuming main thread resources

BUG=698633, 704763
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-30 06:58:28]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 06:58:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-30 06:59:15]

Description was changed from

==========
Get rid of computeVisibleSelectionInDOMTreeDeprecated() in
InputMethodController::textInputType() and textInputInfo()

This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by
replacing
it with |rootEditableElementOf()| with non-canonicalize position from
|textInputInfo()| and |textInputType()| of |InputMethodController| for improving
code health.

Node: Because of selection can't cross editing boundary, root editable element
for
non-canonicalized position and canonicalized position are same.

To make this patch small for merging of workaround of [1], following patch will
replace other use of VisibleSelection::rootEditableElement().

[1] http://crbug.com/704763 Opacity animation consuming main thread resources

BUG=698633, 704763
TEST=n/a; no behavior changes
==========

to

==========
Get rid of computeVisibleSelectionInDOMTreeDeprecated() in
InputMethodController::textInputType() and textInputInfo()

This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by
replacing
it with |rootEditableElementOf()| with non-canonicalize position from
|textInputInfo()| and |textInputType()| of |InputMethodController| for improving
code health.

Node: Because of selection can't cross editing boundary, root editable element
for
non-canonicalized position and canonicalized position are same.

This patch is intentionally not change all call sites of |rootEditableElement()|
in |InputMethodController| to merge this patch as workaround of [1].

[1] http://crbug.com/704763 Opacity animation consuming main thread resources

BUG=698633, 704763
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-30 08:30:08]

PTAL

PS#3 is all green. It seems bots are flaky...

[tkent, 2017-03-30 08:39:05]

lgtm

[commit-bot: I haz the power, 2017-03-30 08:57:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 08:57:45]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-03-30 08:58:29]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-30 08:58:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 09:03:05]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490864309252470,
"parent_rev": "e6feb6d75d95126f683bd932488ecdea9891e356", "commit_rev":
"9744d5bffb3fbdf761455b355ebc4faa757d1aaf"}

[commit-bot: I haz the power, 2017-03-30 09:03:51]

Description was changed from

==========
Get rid of computeVisibleSelectionInDOMTreeDeprecated() in
InputMethodController::textInputType() and textInputInfo()

This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by
replacing
it with |rootEditableElementOf()| with non-canonicalize position from
|textInputInfo()| and |textInputType()| of |InputMethodController| for improving
code health.

Node: Because of selection can't cross editing boundary, root editable element
for
non-canonicalized position and canonicalized position are same.

This patch is intentionally not change all call sites of |rootEditableElement()|
in |InputMethodController| to merge this patch as workaround of [1].

[1] http://crbug.com/704763 Opacity animation consuming main thread resources

BUG=698633, 704763
TEST=n/a; no behavior changes
==========

to

==========
Get rid of computeVisibleSelectionInDOMTreeDeprecated() in
InputMethodController::textInputType() and textInputInfo()

This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by
replacing
it with |rootEditableElementOf()| with non-canonicalize position from
|textInputInfo()| and |textInputType()| of |InputMethodController| for improving
code health.

Node: Because of selection can't cross editing boundary, root editable element
for
non-canonicalized position and canonicalized position are same.

This patch is intentionally not change all call sites of |rootEditableElement()|
in |InputMethodController| to merge this patch as workaround of [1].

[1] http://crbug.com/704763 Opacity animation consuming main thread resources

BUG=698633, 704763
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2782413002
Cr-Commit-Position: refs/heads/master@{#460705}
Committed:
https://chromium.googlesource.com/chromium/src/+/9744d5bffb3fbdf761455b355ebc...
==========

[commit-bot: I haz the power, 2017-03-30 09:03:52]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9744d5bffb3fbdf761455b355ebc...

[sullivan, 2017-03-30 22:05:47]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2785333002/ by sullivan@chromium.org.

The reason for reverting is: This causes a crash in a telemetry benchmark on
android. To reproduce, run:

src/tools/perf/run_benchmark -v --browser=android-chromium
--output-format=chartjson --upload-results --pageset-repeat=1
--also-run-disabled-tests --story-filter=browse:media:youtube
system_health.common_mobile

BUG=706865.

[yosin_UTC9, 2017-04-11 06:58:22]

Reland since crash, CHECK(clean layout tree) after update layout with VIDEO with
text track,
is solved[1].

[1] http://crreb.com/372245 ⚐	LayoutTextTrackContainer::layout() should not
modify DOM tree

[yosin_UTC9, 2017-04-11 06:58:24]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-04-11 06:58:25]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2782413002/#ps80001
(title: "2017-04-11T15:54:13 Rename for Grate Blink Renaming")

[commit-bot: I haz the power, 2017-04-11 06:58:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 08:33:42]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491893904818190,
"parent_rev": "68130af4b73ed4f2b62abb4d74b5da59a3854ea1", "commit_rev":
"e14aacd2baf5cf9c4a5e457384e0b0f73c0163c4"}

[commit-bot: I haz the power, 2017-04-11 08:38:49]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491893904818190,
"parent_rev": "68130af4b73ed4f2b62abb4d74b5da59a3854ea1", "commit_rev":
"e14aacd2baf5cf9c4a5e457384e0b0f73c0163c4"}

[commit-bot: I haz the power, 2017-04-11 08:38:52]

Description was changed from

==========
Get rid of computeVisibleSelectionInDOMTreeDeprecated() in
InputMethodController::textInputType() and textInputInfo()

This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by
replacing
it with |rootEditableElementOf()| with non-canonicalize position from
|textInputInfo()| and |textInputType()| of |InputMethodController| for improving
code health.

Node: Because of selection can't cross editing boundary, root editable element
for
non-canonicalized position and canonicalized position are same.

This patch is intentionally not change all call sites of |rootEditableElement()|
in |InputMethodController| to merge this patch as workaround of [1].

[1] http://crbug.com/704763 Opacity animation consuming main thread resources

BUG=698633, 704763
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2782413002
Cr-Commit-Position: refs/heads/master@{#460705}
Committed:
https://chromium.googlesource.com/chromium/src/+/9744d5bffb3fbdf761455b355ebc...
==========

to

==========
Get rid of computeVisibleSelectionInDOMTreeDeprecated() in
InputMethodController::textInputType() and textInputInfo()

This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by
replacing
it with |rootEditableElementOf()| with non-canonicalize position from
|textInputInfo()| and |textInputType()| of |InputMethodController| for improving
code health.

Node: Because of selection can't cross editing boundary, root editable element
for
non-canonicalized position and canonicalized position are same.

This patch is intentionally not change all call sites of |rootEditableElement()|
in |InputMethodController| to merge this patch as workaround of [1].

[1] http://crbug.com/704763 Opacity animation consuming main thread resources

BUG=698633, 704763
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2782413002
Cr-Original-Commit-Position: refs/heads/master@{#460705}
Committed:
https://chromium.googlesource.com/chromium/src/+/9744d5bffb3fbdf761455b355ebc...
Review-Url: https://codereview.chromium.org/2782413002
Cr-Commit-Position: refs/heads/master@{#463575}
Committed:
https://chromium.googlesource.com/chromium/src/+/e14aacd2baf5cf9c4a5e457384e0...
==========

[commit-bot: I haz the power, 2017-04-11 08:38:53]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e14aacd2baf5cf9c4a5e457384e0...

[sullivan, 2017-04-26 13:09:36]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2843943002/ by sullivan@chromium.org.

The reason for reverting is: This caused large memory regressions. See
http://crbug.com/711366 for details.

BUG=711366.