tools/perf/benchmarks/media.py - Issue 2843913003: Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/media.py

Issue 2843913003: Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag. (Closed)

Patch Set: dalecurtis comments and deps update Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/media.py

diff --git a/tools/perf/benchmarks/media.py b/tools/perf/benchmarks/media.py

index f37ce44021b758f3313ac0385402b297fbfa62d3..592b120e3c17212330f25b54f99492a12960adff 100644

--- a/tools/perf/benchmarks/media.py

+++ b/tools/perf/benchmarks/media.py

@@ -150,8 +150,7 @@ class MediaAndroidToughVideoCasesTBMv2(_MediaTBMv2Benchmark):

# By default, Chrome on Android does not allow autoplay

# of media: it requires a user gesture event to start a video.

# The following option works around that.

- options.AppendExtraBrowserArgs(

- ['--disable-gesture-requirement-for-media-playback'])

+ options.AppendExtraBrowserArgs(['--ignore-autoplay-restrictions'])

@benchmark.Enabled('chromeos')

@@ -205,4 +204,4 @@ class MediaSourceExtensions(perf_benchmark.PerfBenchmark):

# Needed to allow XHR requests to return stream objects.

options.AppendExtraBrowserArgs(

['--enable-experimental-web-platform-features',

- '--disable-gesture-requirement-for-media-playback'])

+ '--ignore-autoplay-restrictions'])

« no previous file with comments | « tools/perf/benchmarks/blink_perf.py ('k') | tools/perf/measurements/media.py » ('j') | no next file with comments »