Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(39)

Issue 2843883002: Remove, or rewrite if necessary, tests which use /deep/ or ::shadow (Closed)

Created:
2 years, 4 months ago by hayato
Modified:
2 years, 4 months ago
Reviewers:
tkent, kochi
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove, or rewrite if necessary, tests which use /deep/ or ::shadow This is a preparation CL for https://codereview.chromium.org/2778983006. There are still other tests which will fail when /deep/ (or ::shadow) is disabled. These tests are being tracked in meta bug 715034. BUG=715034 Review-Url: https://codereview.chromium.org/2843883002 Cr-Commit-Position: refs/heads/master@{#467269} Committed: https://chromium.googlesource.com/chromium/src/+/dc1b7c2d8519a2a441edc32a72bb5d8298b134c9

Patch Set 1 #

Total comments: 2

Patch Set 2 : rev #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1754 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 8 chunks +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/deep-cascade-order.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/deep-cascade-order-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/invalidation/detach-reattach-shadow.html View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/invalidation/detach-reattach-shadow-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/invalidation/shadow-boundary-crossing.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/invalidation/shadow-boundary-crossing-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/invalidation/targeted-class-shadow-combinator.html View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/invalidation/targeted-class-shadow-combinator-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules.html View 2 chunks +0 lines, -48 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/content-deep.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/content-deep-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-deep-combinator-and-host-pseudo-class.html View 1 chunk +0 lines, -122 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-deep-combinator-and-host-pseudo-class-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-shadow-pseudo-element-and-host-pseudo-class.html View 1 chunk +0 lines, -100 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-with-shadow-pseudo-element-and-host-pseudo-class-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/dynamically-added-deep-combinator-and-shadow-pseudo-element.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/dynamically-added-deep-combinator-and-shadow-pseudo-element-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/scrollbar.html View 1 chunk +12 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-and-list-elements.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-and-list-elements-expected.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-pseudo-element.html View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-pseudo-element-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-reprojection-1.html View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-reprojection-1-expected.html View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-reprojection-2.html View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-reprojection-2-expected.html View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/style-and-shadow-element.html View 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/style-and-shadow-element-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/style-with-deep-combinator.html View 1 chunk +0 lines, -384 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/style-with-deep-combinator-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element.html View 1 chunk +0 lines, -308 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/stylesheets-order-in-shadow-dom.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/stylesheets-order-in-shadow-dom-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v0/cascade-deep-in-v1.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v0/cascade-deep-in-v1-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/custom-elements.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp View 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeatureSetTest.cpp View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
hayato
PTAL
2 years, 4 months ago (2017-04-26 06:18:21 UTC) #6
kochi
lgtm https://codereview.chromium.org/2843883002/diff/1/third_party/WebKit/LayoutTests/fast/dom/shadow/dynamically-created-shadow-root.html File third_party/WebKit/LayoutTests/fast/dom/shadow/dynamically-created-shadow-root.html (left): https://codereview.chromium.org/2843883002/diff/1/third_party/WebKit/LayoutTests/fast/dom/shadow/dynamically-created-shadow-root.html#oldcode16 third_party/WebKit/LayoutTests/fast/dom/shadow/dynamically-created-shadow-root.html:16: </html> Although I'm all for removing this test ...
2 years, 4 months ago (2017-04-26 07:12:52 UTC) #7
hayato
https://codereview.chromium.org/2843883002/diff/1/third_party/WebKit/LayoutTests/fast/dom/shadow/dynamically-created-shadow-root.html File third_party/WebKit/LayoutTests/fast/dom/shadow/dynamically-created-shadow-root.html (left): https://codereview.chromium.org/2843883002/diff/1/third_party/WebKit/LayoutTests/fast/dom/shadow/dynamically-created-shadow-root.html#oldcode16 third_party/WebKit/LayoutTests/fast/dom/shadow/dynamically-created-shadow-root.html:16: </html> On 2017/04/26 at 07:12:52, kochi wrote: > Although ...
2 years, 4 months ago (2017-04-26 07:19:18 UTC) #8
hayato
rev
2 years, 4 months ago (2017-04-26 07:26:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843883002/20001
2 years, 4 months ago (2017-04-26 07:26:38 UTC) #14
commit-bot: I haz the power
2 years, 4 months ago (2017-04-26 08:37:16 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dc1b7c2d8519a2a441edc32a72bb...

Powered by Google App Engine
This is Rietveld 408576698