Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2843873002:
Insert CHECK()s to ensure module-related code are not executed without the flag (Closed)
|
Created:
3 years, 8 months ago by hiroshige Modified:
3 years, 7 months ago CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, blink-reviews, rwlbuis, module-dev_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionInsert CHECK()s to ensure module-related code are not executed without the flag
BUG=715376
Review-Url: https://codereview.chromium.org/2843873002
Cr-Commit-Position: refs/heads/master@{#467777}
Committed: https://chromium.googlesource.com/chromium/src/+/089bb9113baa5ada31c80fbb6353e0185a479e6e
Patch Set 1 #Patch Set 2 : Rebase #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 31 (23 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Insert CHECK()s to ensure module-related code are not executed without the flag BUG= ========== to ========== Insert CHECK()s to ensure module-related code are not executed without the flag BUG=715376 ==========
hiroshige@chromium.org changed reviewers: + kouhei@chromium.org
lgtm
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hiroshige@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, kouhei@chromium.org Link to the patchset: https://codereview.chromium.org/2843873002/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hiroshige@chromium.org
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by hiroshige@chromium.org
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by hiroshige@chromium.org
The CQ bit was checked by hiroshige@chromium.org
The CQ bit was unchecked by hiroshige@chromium.org
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493325057512090,
"parent_rev": "803dba30b6180abc7f672ac834ed09b6323f27f8", "commit_rev":
"089bb9113baa5ada31c80fbb6353e0185a479e6e"}
Message was sent while issue was closed.
Description was changed from ========== Insert CHECK()s to ensure module-related code are not executed without the flag BUG=715376 ========== to ========== Insert CHECK()s to ensure module-related code are not executed without the flag BUG=715376 Review-Url: https://codereview.chromium.org/2843873002 Cr-Commit-Position: refs/heads/master@{#467777} Committed: https://chromium.googlesource.com/chromium/src/+/089bb9113baa5ada31c80fbb6353... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/089bb9113baa5ada31c80fbb6353... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
