third_party/WebKit/Source/bindings/core/v8/ScriptModule.h - Issue 2843873002: Insert CHECK()s to ensure module-related code are not executed without the flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptModule.h

Issue 2843873002: Insert CHECK()s to ensure module-related code are not executed without the flag (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptModule.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h

index abc77d7405b15116c7e4ac88111788980d7a2c27..dfb1b85580ed79bfc7ca3dcfe06b523c73edbe7e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h

@@ -33,9 +33,8 @@ class CORE_EXPORT ScriptModule final {

AccessControlStatus);

// TODO(kouhei): Remove copy ctor

- ScriptModule() {}

- ScriptModule(WTF::HashTableDeletedValueType)

- : module_(WTF::kHashTableDeletedValue) {}

+ ScriptModule();

+ ScriptModule(WTF::HashTableDeletedValueType);

~ScriptModule();

// Returns exception, if any.

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp » ('j') | no next file with comments »