Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2843763004: [DevTools] Introduce EmulationModel which will encapsulate emulation (Closed)

Created:
3 years, 8 months ago by dgozman
Modified:
3 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Introduce EmulationModel which will encapsulate emulation This ensures proper capability check. This is also the last domain without proper model. BUG=none Review-Url: https://codereview.chromium.org/2843763004 Cr-Commit-Position: refs/heads/master@{#467547} Committed: https://chromium.googlesource.com/chromium/src/+/b4f933304978b13305405251180bbae0da7cad78

Patch Set 1 #

Patch Set 2 : +deviceorientation #

Patch Set 3 : +css media #

Patch Set 4 : +throttling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -422 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js View 1 2 3 3 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/Source/devtools/front_end/emulation/DeviceOrientation.js View 1 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js View 1 chunk +0 lines, -100 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js View 1 14 chunks +30 lines, -30 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/emulation/TouchModel.js View 1 chunk +0 lines, -141 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/module.json View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js View 1 2 3 chunks +12 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/module.json View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js View 2 chunks +4 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/sdk/EmulationModel.js View 1 2 3 1 chunk +288 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Target.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/module.json View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
dgozman
Please take a look.
3 years, 8 months ago (2017-04-26 01:37:54 UTC) #4
pfeldman
lgtm
3 years, 8 months ago (2017-04-26 23:42:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843763004/60001
3 years, 8 months ago (2017-04-27 01:46:26 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-27 01:55:47 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b4f933304978b13305405251180b...

Powered by Google App Engine
This is Rietveld 408576698