third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js - Issue 2843763004: [DevTools] Introduce EmulationModel which will encapsulate emulation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

Issue 2843763004: [DevTools] Introduce EmulationModel which will encapsulate emulation (Closed)

Patch Set: +throttling Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/module.json ('k') | third_party/WebKit/Source/devtools/front_end/sdk/EmulationModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js b/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

index a1250e94dfecf27a09c21f88ca61c025d82f7514..522340038e0cbc826839f3d7f6219b4a049a22a9 100644

--- a/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

+++ b/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

@@ -130,7 +130,8 @@ Screencast.ScreencastView = class extends UI.VBox {

'jpeg', 80, Math.floor(Math.min(maxImageDimension, dimensions.width)),

Math.floor(Math.min(maxImageDimension, dimensions.height)), undefined, this._screencastFrame.bind(this),

this._screencastVisibilityChanged.bind(this));

- Emulation.MultitargetTouchModel.instance().setCustomTouchEnabled(true);

+ for (var emulationModel of SDK.targetManager.models(SDK.EmulationModel))

+ emulationModel.overrideEmulateTouch(true);

if (this._overlayModel)

this._overlayModel.setHighlighter(this);

}

@@ -140,7 +141,8 @@ Screencast.ScreencastView = class extends UI.VBox {

return;

this._isCasting = false;

this._screenCaptureModel.stopScreencast();

- Emulation.MultitargetTouchModel.instance().setCustomTouchEnabled(false);

+ for (var emulationModel of SDK.targetManager.models(SDK.EmulationModel))

+ emulationModel.overrideEmulateTouch(false);

if (this._overlayModel)

this._overlayModel.setHighlighter(null);

}