Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2843673002: [Extensions Bindings] Use gin::Arguments::GetAll() (Closed)

Created:
3 years, 8 months ago by Devlin
Modified:
3 years, 8 months ago
Reviewers:
jbroman
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, lazyboy
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Use gin::Arguments::GetAll() We recently added a GetAll() method to retrieve all arguments from a gin::Arguments object without conversion. Use it. BUG=653596 Review-Url: https://codereview.chromium.org/2843673002 Cr-Commit-Position: refs/heads/master@{#466870} Committed: https://chromium.googlesource.com/chromium/src/+/1a9ce8910080635cbaf779c1bf42efd927108371

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -22 lines) Patch
M extensions/renderer/api_binding.cc View 1 chunk +1 line, -5 lines 0 comments Download
M extensions/renderer/chrome_setting.cc View 1 chunk +1 line, -5 lines 0 comments Download
M extensions/renderer/declarative_event.cc View 1 chunk +1 line, -7 lines 0 comments Download
M extensions/renderer/storage_area.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Devlin
jbroman@, mind taking a quick look? (Just cleanup.) lazyboy@, FYI.
3 years, 8 months ago (2017-04-25 00:32:19 UTC) #3
jbroman
lgtm
3 years, 8 months ago (2017-04-25 01:29:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843673002/1
3 years, 8 months ago (2017-04-25 01:32:11 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 02:15:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a9ce8910080635cbaf779c1bf42...

Powered by Google App Engine
This is Rietveld 408576698