Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: extensions/renderer/storage_area.cc

Issue 2843673002: [Extensions Bindings] Use gin::Arguments::GetAll() (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/declarative_event.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/storage_area.cc
diff --git a/extensions/renderer/storage_area.cc b/extensions/renderer/storage_area.cc
index d30173992e24396407534bd79232b1dc233e9f32..b952460c06009743aa2c15473990f6fbd4456b87 100644
--- a/extensions/renderer/storage_area.cc
+++ b/extensions/renderer/storage_area.cc
@@ -183,11 +183,7 @@ void StorageArea::HandleFunctionCall(const std::string& method_name,
v8::HandleScope handle_scope(isolate);
v8::Local<v8::Context> context = arguments->GetHolderCreationContext();
- std::vector<v8::Local<v8::Value>> argument_list;
- if (arguments->Length() > 0) {
- // Just copying handles should never fail.
- CHECK(arguments->GetRemaining(&argument_list));
- }
+ std::vector<v8::Local<v8::Value>> argument_list = arguments->GetAll();
std::unique_ptr<base::ListValue> converted_arguments;
v8::Local<v8::Function> callback;
« no previous file with comments | « extensions/renderer/declarative_event.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698