Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2843563002:
Use TaskScheduler instead of blocking pool in captive_portal_browsertest.cc. (Closed)
DescriptionUse TaskScheduler instead of blocking pool in captive_portal_browsertest.cc.
The blocking pool is being deprecated in favor of TaskScheduler.
BUG=667892
R=mmenke@chromium.org
Review-Url: https://codereview.chromium.org/2843563002
Cr-Commit-Position: refs/heads/master@{#467726}
Committed: https://chromium.googlesource.com/chromium/src/+/813697089a01c0a92b202cc6643d78a88e2f361e
Patch Set 1 #
Total comments: 2
Patch Set 2 : remove-extra-traits #Patch Set 3 : fix-build-error #Messages
Total messages: 22 (15 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
PTAL! This CL was generated automatically. Please make sure that the appropriate TaskTraits are used to post tasks. https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h If everything looks good, please lgtm and CQ this CL. Otherwise, tell us what's wrong. Thanks! - FAQ - What if bots are red? Ignore this CL. A human will look at errors shortly. What if the task priority is not set explicitly (no .WithTaskPriority())? When there is no explicit priority, the priority is inherited from the calling context (e.g. a task posted from a BACKGROUND task without an explicit priority will have a BACKGROUND priority). What if the shutdown behavior is not set explicitly (no .WithShutdownBehavior())? If shutdown behavior is important for a task, it should be set explicitly. It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or SKIP_ON_SHUTDOWN.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2843563002/diff/1/chrome/browser/captive_port... File chrome/browser/captive_portal/captive_portal_browsertest.cc (right): https://codereview.chromium.org/2843563002/diff/1/chrome/browser/captive_port... chrome/browser/captive_portal/captive_portal_browsertest.cc:503: base::TaskShutdownBehavior::SKIP_ON_SHUTDOWN))); Do we really need all this stuff? I'd think that just MayBlock() alone is fine, and for the rest we can use defaults, we don't really care. Don't like adding dozens of lines of code that aren't necessary - makes the code needlessly hard to follow.
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Please take another look https://codereview.chromium.org/2843563002/diff/1/chrome/browser/captive_port... File chrome/browser/captive_portal/captive_portal_browsertest.cc (right): https://codereview.chromium.org/2843563002/diff/1/chrome/browser/captive_port... chrome/browser/captive_portal/captive_portal_browsertest.cc:503: base::TaskShutdownBehavior::SKIP_ON_SHUTDOWN))); On 2017/04/25 15:55:10, mmenke wrote: > Do we really need all this stuff? I'd think that just MayBlock() alone is fine, > and for the rest we can use defaults, we don't really care. Don't like adding > dozens of lines of code that aren't necessary - makes the code needlessly hard > to follow. Done.
On 2017/04/27 13:05:43, fdoray wrote: > Please take another look > > https://codereview.chromium.org/2843563002/diff/1/chrome/browser/captive_port... > File chrome/browser/captive_portal/captive_portal_browsertest.cc (right): > > https://codereview.chromium.org/2843563002/diff/1/chrome/browser/captive_port... > chrome/browser/captive_portal/captive_portal_browsertest.cc:503: > base::TaskShutdownBehavior::SKIP_ON_SHUTDOWN))); > On 2017/04/25 15:55:10, mmenke wrote: > > Do we really need all this stuff? I'd think that just MayBlock() alone is > fine, > > and for the rest we can use defaults, we don't really care. Don't like adding > > dozens of lines of code that aren't necessary - makes the code needlessly hard > > to follow. > > Done. Awesome! LGTM!
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493312833705890,
"parent_rev": "5cff918de35f1a3379d8fce7984eef770e1e2d44", "commit_rev":
"813697089a01c0a92b202cc6643d78a88e2f361e"}
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of blocking pool in captive_portal_browsertest.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=mmenke@chromium.org ========== to ========== Use TaskScheduler instead of blocking pool in captive_portal_browsertest.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=mmenke@chromium.org Review-Url: https://codereview.chromium.org/2843563002 Cr-Commit-Position: refs/heads/master@{#467726} Committed: https://chromium.googlesource.com/chromium/src/+/813697089a01c0a92b202cc6643d... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/813697089a01c0a92b202cc6643d... |
