Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: chrome/browser/captive_portal/captive_portal_browsertest.cc

Issue 2843563002: Use TaskScheduler instead of blocking pool in captive_portal_browsertest.cc. (Closed)
Patch Set: fix-build-error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/captive_portal/captive_portal_browsertest.cc
diff --git a/chrome/browser/captive_portal/captive_portal_browsertest.cc b/chrome/browser/captive_portal/captive_portal_browsertest.cc
index 90f95be8562f0a2832f01814305ad5b8d37a49fc..75bdd53ef4e15f255984d8d84ca59d0d89d9e3bd 100644
--- a/chrome/browser/captive_portal/captive_portal_browsertest.cc
+++ b/chrome/browser/captive_portal/captive_portal_browsertest.cc
@@ -18,7 +18,7 @@
#include "base/message_loop/message_loop.h"
#include "base/path_service.h"
#include "base/strings/utf_string_conversions.h"
-#include "base/threading/sequenced_worker_pool.h"
+#include "base/task_scheduler/post_task.h"
#include "base/values.h"
#include "build/build_config.h"
#include "chrome/browser/captive_portal/captive_portal_service.h"
@@ -482,6 +482,8 @@ URLRequestMockCaptivePortalJobFactory::Interceptor::MaybeInterceptRequest(
net::NetworkDelegate* network_delegate) const {
EXPECT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ const base::TaskTraits kTraits = base::TaskTraits().MayBlock();
+
// The PathService is threadsafe.
base::FilePath root_http;
PathService::Get(chrome::DIR_TEST_DATA, &root_http);
@@ -493,11 +495,9 @@ URLRequestMockCaptivePortalJobFactory::Interceptor::MaybeInterceptRequest(
// Once logged in to the portal, HTTPS requests return the page that was
// actually requested.
return new URLRequestMockHTTPJob(
- request,
- network_delegate,
+ request, network_delegate,
root_http.Append(FILE_PATH_LITERAL("title2.html")),
- BrowserThread::GetBlockingPool()->GetTaskRunnerWithShutdownBehavior(
- base::SequencedWorkerPool::SKIP_ON_SHUTDOWN));
+ base::CreateTaskRunnerWithTraits(kTraits));
} else if (request->url() == kMockHttpsQuickTimeoutUrl) {
if (behind_captive_portal_)
return new URLRequestFailedJob(
@@ -505,11 +505,9 @@ URLRequestMockCaptivePortalJobFactory::Interceptor::MaybeInterceptRequest(
// Once logged in to the portal, HTTPS requests return the page that was
// actually requested.
return new URLRequestMockHTTPJob(
- request,
- network_delegate,
+ request, network_delegate,
root_http.Append(FILE_PATH_LITERAL("title2.html")),
- BrowserThread::GetBlockingPool()->GetTaskRunnerWithShutdownBehavior(
- base::SequencedWorkerPool::SKIP_ON_SHUTDOWN));
+ base::CreateTaskRunnerWithTraits(kTraits));
} else {
// The URL should be the captive portal test URL.
EXPECT_TRUE(request->url() == kMockCaptivePortalTestUrl ||
@@ -520,27 +518,21 @@ URLRequestMockCaptivePortalJobFactory::Interceptor::MaybeInterceptRequest(
// by the captive portal.
if (request->url() == kMockCaptivePortal511Url) {
return new URLRequestMockHTTPJob(
- request,
- network_delegate,
+ request, network_delegate,
root_http.Append(FILE_PATH_LITERAL("captive_portal/page511.html")),
- BrowserThread::GetBlockingPool()->GetTaskRunnerWithShutdownBehavior(
- base::SequencedWorkerPool::SKIP_ON_SHUTDOWN));
+ base::CreateTaskRunnerWithTraits(kTraits));
}
return new URLRequestMockHTTPJob(
- request,
- network_delegate,
+ request, network_delegate,
root_http.Append(FILE_PATH_LITERAL("captive_portal/login.html")),
- BrowserThread::GetBlockingPool()->GetTaskRunnerWithShutdownBehavior(
- base::SequencedWorkerPool::SKIP_ON_SHUTDOWN));
+ base::CreateTaskRunnerWithTraits(kTraits));
}
// After logging in to the portal, the test URLs return a 204 response.
return new URLRequestMockHTTPJob(
- request,
- network_delegate,
+ request, network_delegate,
root_http.Append(FILE_PATH_LITERAL("captive_portal/page204.html")),
- BrowserThread::GetBlockingPool()->GetTaskRunnerWithShutdownBehavior(
- base::SequencedWorkerPool::SKIP_ON_SHUTDOWN));
+ base::CreateTaskRunnerWithTraits(kTraits));
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698