[ios] Partially decouple iOS and macOS GN configuration.

[ios] Partially decouple iOS and macOS GN configuration.

Duplicates configs defined in //build/config/mac/BUILD.gn that
are shared with iOS to //build/config/ios/BUILD.gn. Remove all
conditions testing "is_mac" or "is_ios" (as they are now known
from the filename).

Change dependencies on previously shared targets to select the
correct target based on the "target_os".

BUG=635745
Review-Url: https://codereview.chromium.org/2843493002
Cr-Commit-Position: refs/heads/master@{#467680}
Committed: https://chromium.googlesource.com/chromium/src/+/1982eef8e01ab5e8ce6aeba827faa54c8e88838a

[sdefresne, 2017-04-24 15:37:03]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 15:37:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-04-24 15:50:42]

sdefresne@chromium.org changed reviewers:
+ brettw@chromium.org, rsesek@chromium.org

[sdefresne, 2017-04-24 15:50:43]

Robert: can you check that I did not break anything for mac?
Brett: can you review as OWNERS?

[commit-bot: I haz the power, 2017-04-24 17:06:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 17:06:34]

Dry run: This issue passed the CQ dry run.

[Robert Sesek, 2017-04-24 18:18:31]

LGTM

[sdefresne, 2017-04-25 14:06:41]

Patchset #2 (id:20001) has been deleted

[sdefresne, 2017-04-25 15:47:28]

brettw: ping

[brettw, 2017-04-25 21:14:30]

lgtm

https://codereview.chromium.org/2843493002/diff/1/build/config/mac/BUILD.gn
File build/config/mac/BUILD.gn (right):

https://codereview.chromium.org/2843493002/diff/1/build/config/mac/BUILD.gn#n...
build/config/mac/BUILD.gn:67: # (Included by system header. Also exists on iOS
but not included.)
Does this sentence about existing on iOS still apply? It seems like maybe we
should delete it.

[sdefresne, 2017-04-27 13:06:40]

Thank you.

https://codereview.chromium.org/2843493002/diff/1/build/config/mac/BUILD.gn
File build/config/mac/BUILD.gn (right):

https://codereview.chromium.org/2843493002/diff/1/build/config/mac/BUILD.gn#n...
build/config/mac/BUILD.gn:67: # (Included by system header. Also exists on iOS
but not included.)
On 2017/04/25 21:14:30, brettw (plz ping after 24h) wrote:
> Does this sentence about existing on iOS still apply? It seems like maybe we
> should delete it.

Done.

[sdefresne, 2017-04-27 13:06:47]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-04-27 13:06:47]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2843493002/#ps40001
(title: "Address comment.")

[commit-bot: I haz the power, 2017-04-27 13:07:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 15:15:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493298407428260,
"parent_rev": "663c648b8954d605ce9cd9572a9082e94e7f6abd", "commit_rev":
"1982eef8e01ab5e8ce6aeba827faa54c8e88838a"}

[commit-bot: I haz the power, 2017-04-27 15:16:04]

Description was changed from

==========
[ios] Partially decouple iOS and macOS GN configuration.

Duplicates configs defined in //build/config/mac/BUILD.gn that
are shared with iOS to //build/config/ios/BUILD.gn. Remove all
conditions testing "is_mac" or "is_ios" (as they are now known
from the filename).

Change dependencies on previously shared targets to select the
correct target based on the "target_os".

BUG=635745
==========

to

==========
[ios] Partially decouple iOS and macOS GN configuration.

Duplicates configs defined in //build/config/mac/BUILD.gn that
are shared with iOS to //build/config/ios/BUILD.gn. Remove all
conditions testing "is_mac" or "is_ios" (as they are now known
from the filename).

Change dependencies on previously shared targets to select the
correct target based on the "target_os".

BUG=635745

Review-Url: https://codereview.chromium.org/2843493002
Cr-Commit-Position: refs/heads/master@{#467680}
Committed:
https://chromium.googlesource.com/chromium/src/+/1982eef8e01ab5e8ce6aeba827fa...
==========

[commit-bot: I haz the power, 2017-04-27 15:16:05]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1982eef8e01ab5e8ce6aeba827fa...