Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2802)

Unified Diff: build/config/ios/rules.gni

Issue 2843493002: [ios] Partially decouple iOS and macOS GN configuration. (Closed)
Patch Set: Address comment. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/ios/BUILD.gn ('k') | build/config/mac/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ios/rules.gni
diff --git a/build/config/ios/rules.gni b/build/config/ios/rules.gni
index 2cafb96c34f318713353fc42b56220da56699855..5be23dd51969ce895c61c35cee8de7bd3736ded6 100644
--- a/build/config/ios/rules.gni
+++ b/build/config/ios/rules.gni
@@ -102,25 +102,11 @@ template("lipo_binary") {
}
if (enable_stripping) {
- # Check whether //build/config/mac:strip_all has been removed from the
- # configs variables (as this is how stripping is disabled for a single
- # target).
- _strip_all_in_config = false
- if (defined(invoker.configs)) {
- foreach(_config, invoker.configs) {
- if (_config == "//build/config/mac:strip_all") {
- _strip_all_in_config = true
- }
- }
- }
-
- if (_strip_all_in_config) {
- args += [ "-Wcrl,strip,-x,-S" ]
- if (save_unstripped_output) {
- outputs += [ "$root_out_dir/$_output_name.unstripped" ]
- args += [ "-Wcrl,unstripped," +
- rebase_path("$root_out_dir/.", root_build_dir) ]
- }
+ args += [ "-Wcrl,strip,-x,-S" ]
+ if (save_unstripped_output) {
+ outputs += [ "$root_out_dir/$_output_name.unstripped" ]
+ args += [ "-Wcrl,unstripped," +
+ rebase_path("$root_out_dir/.", root_build_dir) ]
}
}
}
« no previous file with comments | « build/config/ios/BUILD.gn ('k') | build/config/mac/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698