Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2843483002: Tidy up fragment loops in SVGInlineTextBoxPainter (Closed)

Created:
3 years, 8 months ago by fs
Modified:
3 years, 8 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Tidy up fragment loops in SVGInlineTextBoxPainter Convert the loop in PaintTextFragments to a for-range, and remove the unneeded local variable in CollectFragmentsInRange. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2843483002 Cr-Commit-Position: refs/heads/master@{#466696} Committed: https://chromium.googlesource.com/chromium/src/+/136757e4c0f776623264be10696a68afec588a8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
fs
3 years, 8 months ago (2017-04-24 15:10:48 UTC) #6
Stephen Chennney
On 2017/04/24 15:10:48, fs wrote: lgtm
3 years, 8 months ago (2017-04-24 15:46:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843483002/1
3 years, 8 months ago (2017-04-24 18:24:37 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 18:34:34 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/136757e4c0f776623264be10696a...

Powered by Google App Engine
This is Rietveld 408576698