Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 2843473002: Revert of [builtins] DeleteProperty: Handle last-added fast properties (Closed)

Created:
3 years, 7 months ago by Michael Achenbach
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [builtins] DeleteProperty: Handle last-added fast properties (patchset #2 id:20001 of https://codereview.chromium.org/2830093002/ ) Reason for revert: Breaks: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/12920 and https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/10281 Original issue's description: > [builtins] DeleteProperty: Handle last-added fast properties > > In general, deleting a property from a fast-properties object > requires transitioning the object to dictionary mode. However, > when the most-recently-added property is deleted, we can simply > roll back the last map transition that the object went through. > > This is a performance experiment: it should make things faster, > but if it turns out to have more negative than positive impact, > we will have to revert it. > > TBR=bmeurer@chromium.org (just adding a comment) > > Review-Url: https://codereview.chromium.org/2830093002 > Cr-Commit-Position: refs/heads/master@{#44799} > Committed: https://chromium.googlesource.com/v8/v8/+/98acfb36e1acf2ab52ab6b6439eb6356c83dcda6 TBR=ishell@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2843473002 Cr-Commit-Position: refs/heads/master@{#44806} Committed: https://chromium.googlesource.com/v8/v8/+/852a20b08c031690db262e257f87d0bb664a86ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -119 lines) Patch
M src/builtins/builtins-internal-gen.cc View 2 chunks +2 lines, -81 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ic/accessor-assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/accessor-assembler.cc View 3 chunks +10 lines, -19 lines 0 comments Download
M src/objects.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M test/mjsunit/dictionary-properties.js View 2 chunks +0 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-252797.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [builtins] DeleteProperty: Handle last-added fast properties
3 years, 7 months ago (2017-04-24 14:52:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843473002/1
3 years, 7 months ago (2017-04-24 14:52:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/852a20b08c031690db262e257f87d0bb664a86ea
3 years, 7 months ago (2017-04-24 14:53:04 UTC) #6
Jakob Kummerow
3 years, 7 months ago (2017-04-24 15:05:23 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2840583002/ by jkummerow@chromium.org.

The reason for reverting is: relanding with fix.

Powered by Google App Engine
This is Rietveld 408576698