Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2843443003: [EasyUnlock] Delete unused BLE code. (Closed)

Created:
3 years, 8 months ago by Tim Song
Modified:
3 years, 7 months ago
Reviewers:
Finnur, sacomoto
CC:
chromium-reviews, extensions-reviews_chromium.org, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, chromium-apps-reviews_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[EasyUnlock] Delete components/proximity_auth/ble directory. This code was used in our old BLE protocol, which is now obsolete. Review-Url: https://codereview.chromium.org/2843443003 Cr-Commit-Position: refs/heads/master@{#467914} Committed: https://chromium.googlesource.com/chromium/src/+/840f5cbdf11218a2eeb85e5f94573907a612f45b

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : remove BUILD file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2113 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D components/proximity_auth/ble/BUILD.gn View 1 2 1 chunk +0 lines, -62 lines 0 comments Download
D components/proximity_auth/ble/OWNERS View 1 chunk +0 lines, -7 lines 0 comments Download
D components/proximity_auth/ble/bluetooth_low_energy_connection.h View 1 chunk +0 lines, -320 lines 0 comments Download
D components/proximity_auth/ble/bluetooth_low_energy_connection.cc View 1 chunk +0 lines, -621 lines 0 comments Download
D components/proximity_auth/ble/bluetooth_low_energy_connection_unittest.cc View 1 chunk +0 lines, -720 lines 0 comments Download
D components/proximity_auth/ble/bluetooth_low_energy_device_whitelist.h View 1 chunk +0 lines, -72 lines 0 comments Download
D components/proximity_auth/ble/bluetooth_low_energy_device_whitelist.cc View 1 chunk +0 lines, -114 lines 0 comments Download
D components/proximity_auth/ble/bluetooth_low_energy_device_whitelist_unittest.cc View 1 chunk +0 lines, -163 lines 0 comments Download
D components/proximity_auth/ble/pref_names.h View 1 chunk +0 lines, -16 lines 0 comments Download
D components/proximity_auth/ble/pref_names.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
Tim Song
3 years, 8 months ago (2017-04-24 23:50:56 UTC) #3
sacomoto
lgtm
3 years, 8 months ago (2017-04-25 09:45:59 UTC) #4
Tim Song
+finnur for chrome/browser/extensions/BUILD.gn
3 years, 7 months ago (2017-04-26 17:37:30 UTC) #7
Finnur
LGTM
3 years, 7 months ago (2017-04-27 14:47:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843443003/40001
3 years, 7 months ago (2017-04-28 01:39:14 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/203681)
3 years, 7 months ago (2017-04-28 03:11:56 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843443003/40001
3 years, 7 months ago (2017-04-28 05:26:32 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 06:03:56 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/840f5cbdf11218a2eeb85e5f9457...

Powered by Google App Engine
This is Rietveld 408576698