Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2843253002: Remove SetFixedContainerSizeDelta from LayerPositionConstraintUnittest (Closed)

Created:
3 years, 8 months ago by pdr.
Modified:
3 years, 8 months ago
Reviewers:
ajuma, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SetFixedContainerSizeDelta from LayerPositionConstraintUnittest This function just wrapped simple logic and we can explicitly call SetViewportBoundsDelta on the correct layer instead. This is similar to https://codereview.chromium.org/2839533002 which removed FixedContainerSizeDelta. BUG=693740 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2843253002 Cr-Commit-Position: refs/heads/master@{#467539} Committed: https://chromium.googlesource.com/chromium/src/+/ce1b52c931d839be349c13b0d4256ead6075336f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -27 lines) Patch
M cc/layers/layer_position_constraint_unittest.cc View 16 chunks +30 lines, -27 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
pdr.
3 years, 8 months ago (2017-04-26 22:58:37 UTC) #2
enne (OOO)
lgtm
3 years, 8 months ago (2017-04-27 01:04:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843253002/1
3 years, 8 months ago (2017-04-27 01:18:35 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-27 01:25:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ce1b52c931d839be349c13b0d425...

Powered by Google App Engine
This is Rietveld 408576698