Remove Layer/LayerImpl's FixedContainerSizeDelta

Remove Layer/LayerImpl's FixedContainerSizeDelta

LayerImpl::FixedContainerSizeDelta was only needed for tests and these
tests can be simplified to just access the appropriate container
viewport bounds directly off the property trees.

Layer::FixedContainerSizeDelta has been removed because it is not used.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2839533002
Cr-Commit-Position: refs/heads/master@{#467540}
Committed: https://chromium.googlesource.com/chromium/src/+/8f08ca970029c2cf5ba9235d14efed69dcda91f7

[pdr., 2017-04-24 20:14:40]

pdr@chromium.org changed reviewers:
+ ajuma@chromium.org, enne@chromium.org

[pdr., 2017-04-24 20:14:55]

Followup to https://codereview.chromium.org/2840433002

[ajuma, 2017-04-24 21:22:30]

lgtm

[enne (OOO), 2017-04-25 00:52:20]

https://codereview.chromium.org/2839533002/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/2839533002/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl_unittest.cc:4445: };  // namespace
s/;//

https://codereview.chromium.org/2839533002/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl_unittest.cc:4472:
FixedContainerSizeDelta(inner_viewport_scroll_layer).y());
Can you remove the helper and just say
property_trees->inner_viewport_container_bounds_delta() here (and something
similar elsewhere)?

Are the element ids ever different, or can you just EXPECT_EQ them as well
(possibly in the setup)?

[pdr., 2017-04-26 21:28:21]

Description was changed from

==========
Refactor FixedContainerSizeDelta to use element ids over layer ids

This patch makes LayerImpl::FixedContainerSizeDelta work on element ids
over layer ids, just using "scroll_clip_layer()->element_id()" instead
of calling functions on scroll_clip_layer. A future patch will refactor
scroll_clip_layer_id_ to be scroll_clip_element_id_ which will make this
logic cleaner.

This patch also moves LayerImpl::FixedContainerSizeDelta to the layer
tree impl unittest file because it is only used for tests.
Layer::FixedContainerSizeDelta has been removed because it is not used.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove Layer/LayerImpl's FixedContainerSizeDelta

LayerImpl::FixedContainerSizeDelta was only needed for tests and these
tests can be simplified to just access the appropriate container
viewport bounds directly off the property trees.

Layer::FixedContainerSizeDelta has been removed because it is not used.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2017-04-26 21:29:01]

https://codereview.chromium.org/2839533002/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/2839533002/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl_unittest.cc:4445: };  // namespace
On 2017/04/25 at 00:52:20, enne wrote:
> s/;//

Done, kinda. And more!

https://codereview.chromium.org/2839533002/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl_unittest.cc:4472:
FixedContainerSizeDelta(inner_viewport_scroll_layer).y());
On 2017/04/25 at 00:52:20, enne wrote:
> Can you remove the helper and just say
property_trees->inner_viewport_container_bounds_delta() here (and something
similar elsewhere)?
> 
> Are the element ids ever different, or can you just EXPECT_EQ them as well
(possibly in the setup)?

This is a real good idea. I was focused on the goal of removing
scroll_clip_layer_id_ and missed the forest for the trees.

Latest patch fully removes FixedContainerSizeDelta and makes all of this code
much simpler.

[pdr., 2017-04-26 21:29:36]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 21:30:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 23:13:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 23:13:49]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2017-04-27 00:57:38]

lgtm !!!

[pdr., 2017-04-27 01:17:47]

The CQ bit was checked by pdr@chromium.org

[pdr., 2017-04-27 01:17:47]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2839533002/#ps20001
(title: "Remove FixedContainerSizeDelta")

[commit-bot: I haz the power, 2017-04-27 01:18:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 01:25:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493255867111840,
"parent_rev": "ce1b52c931d839be349c13b0d4256ead6075336f", "commit_rev":
"8f08ca970029c2cf5ba9235d14efed69dcda91f7"}

[commit-bot: I haz the power, 2017-04-27 01:25:50]

Description was changed from

==========
Remove Layer/LayerImpl's FixedContainerSizeDelta

LayerImpl::FixedContainerSizeDelta was only needed for tests and these
tests can be simplified to just access the appropriate container
viewport bounds directly off the property trees.

Layer::FixedContainerSizeDelta has been removed because it is not used.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove Layer/LayerImpl's FixedContainerSizeDelta

LayerImpl::FixedContainerSizeDelta was only needed for tests and these
tests can be simplified to just access the appropriate container
viewport bounds directly off the property trees.

Layer::FixedContainerSizeDelta has been removed because it is not used.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2839533002
Cr-Commit-Position: refs/heads/master@{#467540}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f08ca970029c2cf5ba9235d14ef...
==========

[commit-bot: I haz the power, 2017-04-27 01:25:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8f08ca970029c2cf5ba9235d14ef...