Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2843163002: MD Settings: Fix networking config errors (Closed)

Created:
3 years, 8 months ago by stevenjb
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix networking config errors This CL: * Correctly handles errors from chrome when a guid becomes stale. * Updates EAP properties in the networking_private IDl and in onc_spec.md. * Fixes networking_private_chromeos.cc to not set empty proxy values. BUG=714210, 710238 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2839693003 Cr-Commit-Position: refs/heads/master@{#467131} (cherry picked from commit 382dc5ad70e096a8df3fea9c80e47e372bb04d00) Review-Url: https://codereview.chromium.org/2843163002 . Cr-Commit-Position: refs/branch-heads/3071@{#236} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/8d3d3844b0dd6cfb8a3a54d4a012fcbdf5268a59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -17 lines) Patch
M chrome/browser/resources/settings/internet_page/internet_detail_page.js View 1 chunk +15 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_subpage.js View 1 chunk +6 lines, -4 lines 0 comments Download
M chromeos/network/onc/onc_signature.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/onc/docs/onc_spec.md View 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_chromeos.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M extensions/common/api/networking_onc.idl View 1 chunk +4 lines, -1 line 0 comments Download
M extensions/common/api/networking_private.idl View 2 chunks +8 lines, -2 lines 0 comments Download
M third_party/closure_compiler/externs/networking_private.js View 7 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
stevenjb
3 years, 8 months ago (2017-04-26 21:21:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8d3d3844b0dd6cfb8a3a54d4a012fcbdf5268a59.

Powered by Google App Engine
This is Rietveld 408576698