Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/255972) mac_chromium_compile_dbg_ng on ...
3 years, 8 months ago
(2017-04-26 21:14:54 UTC)
#4
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/430952)
3 years, 7 months ago
(2017-04-26 23:35:07 UTC)
#8
Description was changed from ========== Move more files to platform/bindings Moves TraceWrapperMember and SharedPersistent to ...
3 years, 7 months ago
(2017-04-27 19:41:32 UTC)
#9
Description was changed from
==========
Move more files to platform/bindings
Moves TraceWrapperMember and SharedPersistent to platform/bindings.
BUG=682322
==========
to
==========
Move more files to platform/bindings
Moves TraceWrapperMember, SharedPersistent, IDLDictionaryBase and ToV8 to
platform/bindings. Also moves some ScriptValue functions in ToV8 to ToV8ForCore
as ScriptValue is not moving to platform/bindings right now.
BUG=682322
==========
adithyas
The CQ bit was checked by adithyas@chromium.org to run a CQ dry run
3 years, 7 months ago
(2017-04-27 19:41:38 UTC)
#10
3 years, 7 months ago
(2017-04-27 19:42:30 UTC)
#13
jbroman
lgtm I'm a little on the fence about IDLDictionaryBase because it seems like the IDL ...
3 years, 7 months ago
(2017-04-27 19:45:23 UTC)
#14
lgtm
I'm a little on the fence about IDLDictionaryBase because it seems like the IDL
stuff is still pretty dependent on core, but I don't feel strongly.
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago
(2017-04-27 19:58:48 UTC)
#15
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/356589) linux_chromium_chromeos_ozone_rel_ng on ...
3 years, 7 months ago
(2017-04-27 19:58:49 UTC)
#16
On 2017/04/27 19:45:23, jbroman wrote: > lgtm > > I'm a little on the fence ...
3 years, 7 months ago
(2017-04-28 01:40:46 UTC)
#17
On 2017/04/27 19:45:23, jbroman wrote:
> lgtm
>
> I'm a little on the fence about IDLDictionaryBase because it seems like the
IDL
> stuff is still pretty dependent on core, but I don't feel strongly.
Yeah, I'd prefer keeping IDLDictionaryBase in core/.
LGTM.
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493395195338470, "parent_rev": "fe20a56ce5c36f7a29880586d67ca5e82aea3756", "commit_rev": "96f45ecaf11f2c80b21a98b7fb9c9b9e0f2d8c70"}
3 years, 7 months ago
(2017-04-28 17:56:18 UTC)
#23
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493395195338470,
"parent_rev": "fe20a56ce5c36f7a29880586d67ca5e82aea3756", "commit_rev":
"96f45ecaf11f2c80b21a98b7fb9c9b9e0f2d8c70"}
commit-bot: I haz the power
Description was changed from ========== Move more files to platform/bindings Moves TraceWrapperMember, SharedPersistent, IDLDictionaryBase and ...
3 years, 7 months ago
(2017-04-28 17:56:30 UTC)
#24
Message was sent while issue was closed.
Description was changed from
==========
Move more files to platform/bindings
Moves TraceWrapperMember, SharedPersistent, IDLDictionaryBase and ToV8 to
platform/bindings. Also moves some ScriptValue functions in ToV8 to ToV8ForCore
as ScriptValue is not moving to platform/bindings right now.
BUG=682322
==========
to
==========
Move more files to platform/bindings
Moves TraceWrapperMember, SharedPersistent, IDLDictionaryBase and ToV8 to
platform/bindings. Also moves some ScriptValue functions in ToV8 to ToV8ForCore
as ScriptValue is not moving to platform/bindings right now.
BUG=682322
Review-Url: https://codereview.chromium.org/2843143002
Cr-Commit-Position: refs/heads/master@{#468053}
Committed:
https://chromium.googlesource.com/chromium/src/+/96f45ecaf11f2c80b21a98b7fb9c...
==========
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/96f45ecaf11f2c80b21a98b7fb9c9b9e0f2d8c70
3 years, 7 months ago
(2017-04-28 17:56:31 UTC)
#25
Issue 2843143002: Move more files to platform/bindings
(Closed)
Created 3 years, 8 months ago by adithyas
Modified 3 years, 7 months ago
Reviewers: haraken, jbroman
Base URL:
Comments: 0