Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2843143002: Move more files to platform/bindings (Closed)

Created:
3 years, 8 months ago by adithyas
Modified:
3 years, 7 months ago
Reviewers:
haraken, jbroman
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more files to platform/bindings Moves TraceWrapperMember, SharedPersistent, IDLDictionaryBase and ToV8 to platform/bindings. Also moves some ScriptValue functions in ToV8 to ToV8ForCore as ScriptValue is not moving to platform/bindings right now. BUG=682322 Review-Url: https://codereview.chromium.org/2843143002 Cr-Commit-Position: refs/heads/master@{#468053} Committed: https://chromium.googlesource.com/chromium/src/+/96f45ecaf11f2c80b21a98b7fb9c9b9e0f2d8c70

Patch Set 1 #

Patch Set 2 : Fix BUILD.gn #

Patch Set 3 : Move ToV8 and IDLDictionaryBase #

Patch Set 4 : Move back IDLDictionaryBase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -520 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/SharedPersistent.h View 1 chunk +3 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ToV8.h View 1 2 1 chunk +3 lines, -303 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ToV8ForCore.h View 1 2 3 2 chunks +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h View 1 chunk +3 lines, -143 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/bindings/SharedPersistent.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/bindings/ToV8.h View 1 2 3 3 chunks +4 lines, -33 lines 0 comments Download
A + third_party/WebKit/Source/platform/bindings/TraceWrapperMember.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (19 generated)
adithyas
3 years, 7 months ago (2017-04-27 19:42:30 UTC) #13
jbroman
lgtm I'm a little on the fence about IDLDictionaryBase because it seems like the IDL ...
3 years, 7 months ago (2017-04-27 19:45:23 UTC) #14
haraken
On 2017/04/27 19:45:23, jbroman wrote: > lgtm > > I'm a little on the fence ...
3 years, 7 months ago (2017-04-28 01:40:46 UTC) #17
adithyas
All right, I moved IDLDictionaryBase back to bindings/.
3 years, 7 months ago (2017-04-28 15:59:56 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843143002/60001
3 years, 7 months ago (2017-04-28 16:00:31 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 17:56:31 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/96f45ecaf11f2c80b21a98b7fb9c...

Powered by Google App Engine
This is Rietveld 408576698