Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2843073002: Remove the GUID requirement from the ContentId (Closed)

Created:
3 years, 8 months ago by David Trainor- moved to gerrit
Modified:
3 years, 7 months ago
Reviewers:
qinmin
CC:
chromium-reviews, David Trainor- moved to gerrit, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the GUID requirement from the ContentId In Java persisting the ContentId required it to be a guid. This removes that dependency. Note that legacy downloads still have their own checks for requiring the id to be a guid, but if the download isn't associated with a legacy download the checks should not occur. BUG=691805 Review-Url: https://codereview.chromium.org/2843073002 Cr-Commit-Position: refs/heads/master@{#467929} Committed: https://chromium.googlesource.com/chromium/src/+/82ecc71c03b9c7a0478849b3df403c1518b05642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntryTest.java View 2 chunks +14 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
David Trainor- moved to gerrit
ptal thanks!
3 years, 8 months ago (2017-04-26 18:49:47 UTC) #2
qinmin
lgtm
3 years, 8 months ago (2017-04-27 05:13:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843073002/1
3 years, 7 months ago (2017-04-28 07:28:00 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 08:13:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/82ecc71c03b9c7a0478849b3df40...

Powered by Google App Engine
This is Rietveld 408576698