Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2140)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

Issue 2843073002: Remove the GUID requirement from the ContentId (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
index 738406b14a526cdea0925adce984ff05b00c18bc..814d12b89a9de60670f062687ec2dadda6931074 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
@@ -1016,7 +1016,7 @@ public class DownloadNotificationService extends Service {
/**
* Add a download failed notification.
* @param id The {@link ContentId} of the download.
- * @param fileName GUID of the download.
+ * @param fileName Filename of the download.
* @param icon A {@link Bitmap} to be used as the large icon for display.
*/
@VisibleForTesting
@@ -1354,7 +1354,7 @@ public class DownloadNotificationService extends Service {
}
ContentId id = getContentIdFromIntent(intent);
- if (id == null || !DownloadSharedPreferenceEntry.isValidGUID(id.id)) return false;
+ if (id == null) return false;
return true;
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698