Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2842903002: [inspector] improved V8Debugger::breakProgram method (Closed)

Created:
3 years, 8 months ago by kozy
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] improved V8Debugger::breakProgram method We should be ready for gone agent. BUG=chromium:714819 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2842903002 Cr-Commit-Position: refs/heads/master@{#44874} Committed: https://chromium.googlesource.com/v8/v8/+/835b71e8cb388a05040200da4ce704082a6d5ce5

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -12 lines) Patch
M src/inspector/v8-debugger.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/v8-debugger.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M src/inspector/v8-debugger-agent-impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A test/inspector/debugger/destory-in-break-program.js View 1 chunk +13 lines, -0 lines 0 comments Download
A test/inspector/debugger/destory-in-break-program-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M test/inspector/inspector-impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M test/inspector/inspector-impl.cc View 3 chunks +20 lines, -6 lines 0 comments Download
M test/inspector/inspector-test.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kozy
Dmitry, please take a look!
3 years, 8 months ago (2017-04-25 22:03:47 UTC) #1
dgozman
lgtm
3 years, 8 months ago (2017-04-25 22:16:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842903002/20001
3 years, 8 months ago (2017-04-25 22:17:33 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 22:55:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/835b71e8cb388a05040200da4ce704082a6...

Powered by Google App Engine
This is Rietveld 408576698