src/inspector/v8-debugger-agent-impl.cc - Issue 2842903002: [inspector] improved V8Debugger::breakProgram method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/inspector/v8-debugger-agent-impl.cc

Issue 2842903002: [inspector] improved V8Debugger::breakProgram method (Closed)

Patch Set: rebased Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/inspector/v8-debugger-agent-impl.cc

diff --git a/src/inspector/v8-debugger-agent-impl.cc b/src/inspector/v8-debugger-agent-impl.cc

index 980b2346f45949d78d9c661a09bc734023510078..431c297a744888b244eaec5a3ec4ac42c11693be 100644

--- a/src/inspector/v8-debugger-agent-impl.cc

+++ b/src/inspector/v8-debugger-agent-impl.cc

@@ -1250,7 +1250,7 @@ void V8DebuggerAgentImpl::breakProgram(

std::vector<BreakReason> currentScheduledReason;

currentScheduledReason.swap(m_breakReason);

pushBreakDetails(breakReason, std::move(data));

- m_debugger->breakProgram();

+ if (!m_debugger->breakProgram(m_session->contextGroupId())) return;

popBreakDetails();

m_breakReason.swap(currentScheduledReason);

if (!m_breakReason.empty()) {

« no previous file with comments | « src/inspector/v8-debugger.cc ('k') | test/inspector/debugger/destory-in-break-program.js » ('j') | no next file with comments »