Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2842893002: Page Info permissions: make font sizes and spacing more consistent. (Closed)

Created:
3 years, 7 months ago by lgarron
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Page Info permissions: make font sizes and spacing more consistent. 1. Change font sizes for permission labels to be consistent to be larger on Views. (Cocoa was already larger.) 2. Change font sizes for permission details strings ("X in use" for cookies", permission decision strings like "Automatically blocked") to be smaller on Cocoa. (Views was already smaller.) 3. Use consistent vertical spacing for detail strings on Cocoa. (Note: "Cookies" is not a permission, but uses similar layout code.) BUG=708358 Review-Url: https://codereview.chromium.org/2834223002 Cr-Commit-Position: refs/heads/master@{#466763} (cherry picked from commit f335b5f72ac30dfee258403ebae955eb162d1867) Review-Url: https://codereview.chromium.org/2842893002 . Cr-Commit-Position: refs/branch-heads/3071@{#207} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/3662335f27cc9303846d2c74f7554cdad90f5b99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm View 4 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/page_info/permission_selector_row.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
lgarron
3 years, 7 months ago (2017-04-25 21:46:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3662335f27cc9303846d2c74f7554cdad90f5b99.

Powered by Google App Engine
This is Rietveld 408576698