Page Info permissions: make font sizes and spacing more consistent.

Page Info permissions: make font sizes and spacing more consistent.

1. Change font sizes for permission labels to be consistent to be larger on Views. (Cocoa was already larger.)
2. Change font sizes for permission details strings ("X in use" for cookies", permission decision strings like "Automatically blocked") to be smaller on Cocoa. (Views was already smaller.)
3. Use consistent vertical spacing for detail strings on Cocoa.

(Note: "Cookies" is not a permission, but uses similar layout code.)

BUG=708358
Review-Url: https://codereview.chromium.org/2834223002
Cr-Commit-Position: refs/heads/master@{#466763}
Committed: https://chromium.googlesource.com/chromium/src/+/f335b5f72ac30dfee258403ebae955eb162d1867

[lgarron, 2017-04-21 23:43:31]

lgarron@chromium.org changed reviewers:
+ msw@chromium.org

[lgarron, 2017-04-21 23:43:32]

msw@, could you review?

[lgarron, 2017-04-21 23:45:52]

Description was changed from

==========
Page Info permissions: make font sizes and spacing more consistent.

1. Change font sizes for permission labels to be consistent to be larger on
Views. (Cocoa was already larger.)
2. Change font sizes for permission details strings ("X in use" for cookies",
permission decision strings like "Automatically blocked") to be smaller on
Cocoa. (Views was already smaller.)
3. Use consistent vertical spacing for detail strings on Cocoa.

BUG=708358
==========

to

==========
Page Info permissions: make font sizes and spacing more consistent.

1. Change font sizes for permission labels to be consistent to be larger on
Views. (Cocoa was already larger.)
2. Change font sizes for permission details strings ("X in use" for cookies",
permission decision strings like "Automatically blocked") to be smaller on
Cocoa. (Views was already smaller.)
3. Use consistent vertical spacing for detail strings on Cocoa.

(Note: "Cookies" is not a permission, but uses similar layout code.)

BUG=708358
==========

[msw, 2017-04-21 23:50:29]

Sorry, I'm out of the loop with ChromeTextContext / TextStyle enums and am not
familiar with Cocoa UI. You should find alternate reviewers.

[lgarron, 2017-04-24 18:58:31]

lgarron@chromium.org changed reviewers:
+ rsesek@chromium.org

[lgarron, 2017-04-24 18:58:32]

msw@: The use of CONTEXT_BODY_TEXT_LARGE for permission labels here directly
mirrors what is done for the functionally-equivalent Cookies label at [1], done
by tapted@ as part of a large change in [2]. tapted@ is out until May, though.
Are you willing to rubber-stamp the one-line fix, or should I find someone else?

rsesek@, could you review Cocoa?
(Cocoa still uses systemFontSize/smallSystemFontSize.)

[1]
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/page_info/page_i...
[2]
https://chromium.googlesource.com/chromium/src/+/9577332120682b5400df78b16edc...

[msw, 2017-04-24 19:05:44]

shrug c/b/ui/views rubber stamp lgtm

[Robert Sesek, 2017-04-24 20:19:52]

lgtm

[lgarron, 2017-04-24 20:24:21]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2017-04-24 20:25:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 21:07:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493065461876750,
"parent_rev": "acb8a289bdc8dccf1e4bd726a29f10b15ed281f8", "commit_rev":
"f335b5f72ac30dfee258403ebae955eb162d1867"}

[commit-bot: I haz the power, 2017-04-24 21:07:53]

Description was changed from

==========
Page Info permissions: make font sizes and spacing more consistent.

1. Change font sizes for permission labels to be consistent to be larger on
Views. (Cocoa was already larger.)
2. Change font sizes for permission details strings ("X in use" for cookies",
permission decision strings like "Automatically blocked") to be smaller on
Cocoa. (Views was already smaller.)
3. Use consistent vertical spacing for detail strings on Cocoa.

(Note: "Cookies" is not a permission, but uses similar layout code.)

BUG=708358
==========

to

==========
Page Info permissions: make font sizes and spacing more consistent.

1. Change font sizes for permission labels to be consistent to be larger on
Views. (Cocoa was already larger.)
2. Change font sizes for permission details strings ("X in use" for cookies",
permission decision strings like "Automatically blocked") to be smaller on
Cocoa. (Views was already smaller.)
3. Use consistent vertical spacing for detail strings on Cocoa.

(Note: "Cookies" is not a permission, but uses similar layout code.)

BUG=708358

Review-Url: https://codereview.chromium.org/2834223002
Cr-Commit-Position: refs/heads/master@{#466763}
Committed:
https://chromium.googlesource.com/chromium/src/+/f335b5f72ac30dfee258403ebae9...
==========

[commit-bot: I haz the power, 2017-04-24 21:07:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f335b5f72ac30dfee258403ebae9...