Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2842793004: Revert of [turbofan] Fix impossible type handling for TypeGuard and BooleanNot. (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Fix impossible type handling for TypeGuard and BooleanNot. (patchset #1 id:1 of https://codereview.chromium.org/2836203004/ ) Reason for revert: Tentative revert for https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/14886 Original issue's description: > [turbofan] Fix impossible type handling for TypeGuard and BooleanNot. > > BUG=chromium:715204 > > Review-Url: https://codereview.chromium.org/2836203004 > Cr-Commit-Position: refs/heads/master@{#44883} > Committed: https://chromium.googlesource.com/v8/v8/+/9c47a061cf325addf8bd2ba4b71a4d1ef210c5d6 TBR=bmeurer@chromium.org,jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:715204 Review-Url: https://codereview.chromium.org/2842793004 Cr-Commit-Position: refs/heads/master@{#44898} Committed: https://chromium.googlesource.com/v8/v8/+/397ebb765ca84954d95116c6ac30c0e3d2c2e993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -24 lines) Patch
M src/compiler/simplified-lowering.cc View 2 chunks +3 lines, -11 lines 0 comments Download
D test/mjsunit/compiler/regress-715204.js View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jgruber
Created Revert of [turbofan] Fix impossible type handling for TypeGuard and BooleanNot.
3 years, 8 months ago (2017-04-26 15:24:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842793004/1
3 years, 8 months ago (2017-04-26 15:24:48 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 15:24:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/397ebb765ca84954d95116c6ac30c0e3d2c...

Powered by Google App Engine
This is Rietveld 408576698