Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2836203004: [turbofan] Fix impossible type handling for TypeGuard and BooleanNot. (Closed)

Created:
3 years, 8 months ago by Jarin
Modified:
3 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix impossible type handling for TypeGuard and BooleanNot. BUG=chromium:715204 Review-Url: https://codereview.chromium.org/2836203004 Cr-Commit-Position: refs/heads/master@{#44883} Committed: https://chromium.googlesource.com/v8/v8/+/9c47a061cf325addf8bd2ba4b71a4d1ef210c5d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M src/compiler/simplified-lowering.cc View 2 chunks +11 lines, -3 lines 0 comments Download
A test/mjsunit/compiler/regress-715204.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Jarin
Could you take a look, please?
3 years, 8 months ago (2017-04-26 09:54:04 UTC) #4
Benedikt Meurer
lgtm
3 years, 8 months ago (2017-04-26 09:56:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836203004/1
3 years, 8 months ago (2017-04-26 10:25:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/9c47a061cf325addf8bd2ba4b71a4d1ef210c5d6
3 years, 8 months ago (2017-04-26 10:27:18 UTC) #12
jgruber
3 years, 8 months ago (2017-04-26 15:24:40 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2842793004/ by jgruber@chromium.org.

The reason for reverting is: Tentative revert for
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds....

Powered by Google App Engine
This is Rietveld 408576698