Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2842693002: cros: Don't send duplicate UserSession mojo messages to ash (Closed)

Created:
3 years, 7 months ago by James Cook
Modified:
3 years, 7 months ago
Reviewers:
xiyuan, oshima, yzshen1
CC:
chromium-reviews, kalyank, rsesek+watch_chromium.org, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Don't send duplicate UserSession mojo messages to ash After the profile is loaded the SessionControllerClient in the browser sends an updated ash::mojom::UserSession to ash. Most of the time the message is the same as the one just sent when the session was started. BUG=714689, 712799 TEST=added to SessionControllerClientTest in unit_tests Review-Url: https://codereview.chromium.org/2842693002 Cr-Commit-Position: refs/heads/master@{#467172} Committed: https://chromium.googlesource.com/chromium/src/+/714f3da6005d557c7dff987fb3ee097201cb31fd

Patch Set 1 #

Total comments: 6

Patch Set 2 : rebase #

Patch Set 3 : use EqualsTraits #

Total comments: 1

Patch Set 4 : review comment #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -4 lines) Patch
M chrome/browser/ui/ash/session_controller_client.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/session_controller_client.cc View 1 2 3 3 chunks +20 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/session_controller_client_unittest.cc View 4 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
James Cook
xiyuan, please take a look. https://codereview.chromium.org/2842693002/diff/1/ui/gfx/image/image_skia.h File ui/gfx/image/image_skia.h (right): https://codereview.chromium.org/2842693002/diff/1/ui/gfx/image/image_skia.h#newcode100 ui/gfx/image/image_skia.h:100: bool Equals(const gfx::ImageSkia& other) ...
3 years, 7 months ago (2017-04-25 00:58:28 UTC) #4
xiyuan
lgtm You still need a gfx owner to stamp on the CL though. https://codereview.chromium.org/2842693002/diff/1/chrome/browser/ui/ash/session_controller_client_unittest.cc File ...
3 years, 7 months ago (2017-04-25 16:04:53 UTC) #7
James Cook
oshima, can I get OWNERS for ui/gfx/image/image_skia.cc?
3 years, 7 months ago (2017-04-25 16:21:06 UTC) #9
oshima
https://codereview.chromium.org/2842693002/diff/1/ui/gfx/image/image_skia.h File ui/gfx/image/image_skia.h (right): https://codereview.chromium.org/2842693002/diff/1/ui/gfx/image/image_skia.h#newcode100 ui/gfx/image/image_skia.h:100: bool Equals(const gfx::ImageSkia& other) const; On 2017/04/25 16:04:53, xiyuan ...
3 years, 7 months ago (2017-04-25 17:28:05 UTC) #10
James Cook
https://codereview.chromium.org/2842693002/diff/1/ui/gfx/image/image_skia.h File ui/gfx/image/image_skia.h (right): https://codereview.chromium.org/2842693002/diff/1/ui/gfx/image/image_skia.h#newcode100 ui/gfx/image/image_skia.h:100: bool Equals(const gfx::ImageSkia& other) const; On 2017/04/25 17:28:04, oshima ...
3 years, 7 months ago (2017-04-25 17:32:47 UTC) #11
oshima
On 2017/04/25 17:32:47, James Cook wrote: > https://codereview.chromium.org/2842693002/diff/1/ui/gfx/image/image_skia.h > File ui/gfx/image/image_skia.h (right): > > https://codereview.chromium.org/2842693002/diff/1/ui/gfx/image/image_skia.h#newcode100 ...
3 years, 7 months ago (2017-04-25 17:49:15 UTC) #12
James Cook
https://codereview.chromium.org/2842693002/diff/1/ui/gfx/image/image_skia.h File ui/gfx/image/image_skia.h (right): https://codereview.chromium.org/2842693002/diff/1/ui/gfx/image/image_skia.h#newcode100 ui/gfx/image/image_skia.h:100: bool Equals(const gfx::ImageSkia& other) const; On 2017/04/25 17:32:47, James ...
3 years, 7 months ago (2017-04-25 17:50:04 UTC) #13
James Cook
yzshen, please take a look at session_controller_client.cc -- is this the right place to put ...
3 years, 7 months ago (2017-04-25 18:31:12 UTC) #15
yzshen1
LGTM for EqualsTraits usage, with one nit. https://codereview.chromium.org/2842693002/diff/40001/chrome/browser/ui/ash/session_controller_client.cc File chrome/browser/ui/ash/session_controller_client.cc (right): https://codereview.chromium.org/2842693002/diff/40001/chrome/browser/ui/ash/session_controller_client.cc#newcode112 chrome/browser/ui/ash/session_controller_client.cc:112: struct EqualsTraits<gfx::ImageSkia, ...
3 years, 7 months ago (2017-04-25 20:17:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842693002/80001
3 years, 7 months ago (2017-04-25 23:34:07 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-04-26 00:12:29 UTC) #22
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/714f3da6005d557c7dff987fb3ee...

Powered by Google App Engine
This is Rietveld 408576698