cros: Don't send duplicate UserSession mojo messages to ash

chrome/browser/ui/ash/session_controller_client_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/session_controller_client.h"
 
 #include <memory>
 #include <string>
 #include <vector>
 
@@ skipping 69 matching lines @@
   }
 
   ash::mojom::SessionInfo* last_session_info() {
     return last_session_info_.get();
   }
 
   ash::mojom::UserSession* last_user_session() {
     return last_user_session_.get();
   }
 
+  int update_user_session_count() { return update_user_session_count_; }
+
   // ash::mojom::SessionController:
   void SetClient(ash::mojom::SessionControllerClientPtr client) override {}
   void SetSessionInfo(ash::mojom::SessionInfoPtr info) override {
     last_session_info_ = info->Clone();
   }
   void UpdateUserSession(ash::mojom::UserSessionPtr user_session) override {
     last_user_session_ = user_session->Clone();
+    update_user_session_count_++;

[xiyuan, 2017/04/25 16:04:53]

nit: pre-increment, i.e. ++update_user_session_count_

   }
   void SetUserSessionOrder(
       const std::vector<uint32_t>& user_session_order) override {}
   void StartLock(const StartLockCallback& callback) override {}
   void NotifyChromeLockAnimationsComplete() override {}
   void RunUnlockAnimation(const RunUnlockAnimationCallback& callback) override {
   }
   void NotifyChromeTerminating() override {}
 
  private:
   mojo::Binding<ash::mojom::SessionController> binding_;
 
   ash::mojom::SessionInfoPtr last_session_info_;
   ash::mojom::UserSessionPtr last_user_session_;
+  int update_user_session_count_ = 0;
 
   DISALLOW_COPY_AND_ASSIGN(TestSessionController);
 };
 
 }  // namespace
 
 class SessionControllerClientTest : public testing::Test {
  protected:
   SessionControllerClientTest() {}
   ~SessionControllerClientTest() override {}
@@ skipping 233 matching lines @@
   const AccountId account_id(AccountId::FromUserEmail(kUser));
   user_manager()->LoginUser(account_id);
   user_profile_->GetPrefs()->SetString(
       prefs::kMultiProfileUserBehavior,
       chromeos::MultiProfileUserController::kBehaviorNotAllowed);
   user_manager()->AddUser(AccountId::FromUserEmail("bb@b.b"));
   EXPECT_EQ(ash::AddUserSessionPolicy::ERROR_NOT_ALLOWED_PRIMARY_USER,
             SessionControllerClient::GetAddUserSessionPolicy());
 }
 
+TEST_F(SessionControllerClientTest, SendUserSession) {
+  // Create an object to test and connect it to our test interface.
+  SessionControllerClient client;
+  TestSessionController session_controller;
+  client.session_controller_ = session_controller.CreateInterfacePtrAndBind();
+  client.Init();
+  SessionControllerClient::FlushForTesting();
+
+  // No user session sent yet.
+  EXPECT_EQ(0, session_controller.update_user_session_count());
+
+  // Simulate login.
+  const AccountId account_id(AccountId::FromUserEmail("user@test.com"));
+  user_manager()->AddUser(account_id);
+  session_manager_.CreateSession(
+      account_id, chromeos::ProfileHelper::GetUserIdHashByUserIdForTesting(
+                      "user@test.com"));
+  SessionControllerClient::FlushForTesting();
+
+  // User session was sent.
+  EXPECT_EQ(1, session_controller.update_user_session_count());
+
+  // Simulate a request for an update where nothing changed.
+  client.SendUserSession(*user_manager()->GetLoggedInUsers()[0]);
+  SessionControllerClient::FlushForTesting();
+
+  // Session was not updated because nothing changed.
+  EXPECT_EQ(1, session_controller.update_user_session_count());
+}
+
 TEST_F(SessionControllerClientTest, SupervisedUser) {
   // Create an object to test and connect it to our test interface.
   SessionControllerClient client;
   TestSessionController session_controller;
   client.session_controller_ = session_controller.CreateInterfacePtrAndBind();
   client.Init();
   SessionControllerClient::FlushForTesting();
 
   // Simulate the login screen. No user session yet.
   session_manager_.SetSessionState(
@@ skipping 40 matching lines @@
 
   // Simulate an update to the custodian information.
   prefs->SetString(prefs::kSupervisedUserCustodianEmail, "parent3@test.com");
   client.OnCustodianInfoChanged();
   SessionControllerClient::FlushForTesting();
 
   // The updated custodian was sent over the mojo interface.
   EXPECT_EQ("parent3@test.com",
             session_controller.last_user_session()->custodian_email);
 }