Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2842673002: [Extensions Bindings] Remove Isolate arg from APIBinding::CreateInstance (Closed)

Created:
3 years, 8 months ago by Devlin
Modified:
3 years, 8 months ago
Reviewers:
jbroman
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, lazyboy
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Remove Isolate arg from APIBinding::CreateInstance There's no need to pass in the Isolate, since we already pass in the context. Remove the Isolate argument from APIBinding::CreateInstance and APIBindingsSystem::CreateAPIInstance. BUG=653596 Review-Url: https://codereview.chromium.org/2842673002 Cr-Commit-Position: refs/heads/master@{#466867} Committed: https://chromium.googlesource.com/chromium/src/+/0aeb4a17feebe95b140cd5385d0513f13c0fe719

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -39 lines) Patch
M extensions/renderer/api_binding.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/api_binding.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/api_binding_unittest.cc View 21 chunks +24 lines, -24 lines 0 comments Download
M extensions/renderer/api_bindings_system.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/api_bindings_system.cc View 2 chunks +1 line, -2 lines 0 comments Download
M extensions/renderer/api_bindings_system_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M extensions/renderer/declarative_event_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/renderer/native_extension_bindings_system.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Devlin
jbroman@ - one more cleanup. :) lazyboy@, FYI.
3 years, 8 months ago (2017-04-25 00:39:35 UTC) #3
jbroman
lgtm
3 years, 8 months ago (2017-04-25 01:44:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842673002/1
3 years, 8 months ago (2017-04-25 01:52:41 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 01:58:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0aeb4a17feebe95b140cd5385d05...

Powered by Google App Engine
This is Rietveld 408576698