extensions/renderer/api_bindings_system.h - Issue 2842673002: [Extensions Bindings] Remove Isolate arg from APIBinding::CreateInstance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_bindings_system.h

Issue 2842673002: [Extensions Bindings] Remove Isolate arg from APIBinding::CreateInstance (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/api_bindings_system.h

diff --git a/extensions/renderer/api_bindings_system.h b/extensions/renderer/api_bindings_system.h

index 9f96dbb4fa5625c98dd324bcf8a56e2a61d64211..138d42d937461d3d8109a026d78d6fb451f928a6 100644

--- a/extensions/renderer/api_bindings_system.h

+++ b/extensions/renderer/api_bindings_system.h

@@ -54,7 +54,6 @@ class APIBindingsSystem {

v8::Local<v8::Object> CreateAPIInstance(

const std::string& api_name,

v8::Local<v8::Context> context,

- v8::Isolate* isolate,

const APIBinding::AvailabilityCallback& is_available,

APIBindingHooks** hooks_out);