Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/check_gn_headers_unittest.py

Issue 2842513003: Optimize check_gn_headers.py for speed (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/check_gn_headers.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/check_gn_headers_unittest.py
diff --git a/build/check_gn_headers_unittest.py b/build/check_gn_headers_unittest.py
index 7272ea960640f8fb3d85f76eabbd5810ec2695f4..f62fe62309548d5c53803a0e2c6791e29c7cb668 100755
--- a/build/check_gn_headers_unittest.py
+++ b/build/check_gn_headers_unittest.py
@@ -58,7 +58,7 @@ a/b/c
class CheckGnHeadersTest(unittest.TestCase):
def testNinja(self):
- headers = check_gn_headers.ParseNinjaDepsOutput(ninja_input)
+ headers = check_gn_headers.ParseNinjaDepsOutput(ninja_input.split('\n'))
expected = set([
'dir/path/b.h',
'c.hh',
@@ -71,7 +71,8 @@ class CheckGnHeadersTest(unittest.TestCase):
old_sep = os.sep
os.sep = '\\'
- headers = check_gn_headers.ParseNinjaDepsOutput(ninja_input_win)
+ headers = check_gn_headers.ParseNinjaDepsOutput(
+ ninja_input_win.split('\n'))
expected = set([
'dir\\path\\b.h',
'c.hh',
« no previous file with comments | « build/check_gn_headers.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698