Chromium Code Reviews
DescriptionFix a recent regression in Speech->Start Speaking on Mac
After a recent refactoring, all RenderWidgetHostViews use TextInputManager in
order to get the value of |selected_text_|. Unfortunately this was not applied
to SpeakText() call inside RenderWidgetHostViewMac and furthermore, the local
variable |selected_text_| was not removed from the view.
BUG=713850
Review-Url: https://codereview.chromium.org/2831183002
Cr-Commit-Position: refs/heads/master@{#466715}
(cherry picked from commit b69ac7cd2ccc200ff53b95b30cbbea962a27e0d3)
Review-Url: https://codereview.chromium.org/2842383002 .
Cr-Commit-Position: refs/branch-heads/3071@{#243}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/50b0fc38c86e7b9994db4d00c5e5e2247b972a2c
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||