Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2842383002: Fix a recent regression in Speech->Start Speaking on Mac (Closed)

Created:
3 years, 8 months ago by EhsanK
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Fix a recent regression in Speech->Start Speaking on Mac After a recent refactoring, all RenderWidgetHostViews use TextInputManager in order to get the value of |selected_text_|. Unfortunately this was not applied to SpeakText() call inside RenderWidgetHostViewMac and furthermore, the local variable |selected_text_| was not removed from the view. BUG=713850 Review-Url: https://codereview.chromium.org/2831183002 Cr-Commit-Position: refs/heads/master@{#466715} (cherry picked from commit b69ac7cd2ccc200ff53b95b30cbbea962a27e0d3) Review-Url: https://codereview.chromium.org/2842383002 . Cr-Commit-Position: refs/branch-heads/3071@{#243} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/50b0fc38c86e7b9994db4d00c5e5e2247b972a2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
EhsanK
3 years, 8 months ago (2017-04-27 00:04:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
50b0fc38c86e7b9994db4d00c5e5e2247b972a2c.

Powered by Google App Engine
This is Rietveld 408576698