Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 2831183002: Fix a recent regression in Speech->Start Speaking on Mac (Closed)

Created:
3 years, 8 months ago by EhsanK
Modified:
3 years, 8 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, mac-reviews_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a recent regression in Speech->Start Speaking on Mac After a recent refactoring, all RenderWidgetHostViews use TextInputManager in order to get the value of |selected_text_|. Unfortunately this was not applied to SpeakText() call inside RenderWidgetHostViewMac and furthermore, the local variable |selected_text_| was not removed from the view. BUG=713850 Review-Url: https://codereview.chromium.org/2831183002 Cr-Commit-Position: refs/heads/master@{#466715} Committed: https://chromium.googlesource.com/chromium/src/+/b69ac7cd2ccc200ff53b95b30cbbea962a27e0d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
EhsanK
Hello Charlie, Could you please take a look at this change. The change is small ...
3 years, 8 months ago (2017-04-20 20:26:02 UTC) #4
Charlie Reis
LGTM
3 years, 8 months ago (2017-04-24 19:01:37 UTC) #7
EhsanK
Thanks! CQ-ing.
3 years, 8 months ago (2017-04-24 19:07:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831183002/1
3 years, 8 months ago (2017-04-24 19:07:52 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 19:26:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b69ac7cd2ccc200ff53b95b30cbb...

Powered by Google App Engine
This is Rietveld 408576698