Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1643)

Issue 2842373002: Initialize |selection_popup_controller_| properly (Closed)

Created:
3 years, 8 months ago by Jinsuk Kim
Modified:
3 years, 7 months ago
Reviewers:
boliu
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize |selection_popup_controller_| properly Set the class var to nullptr in the constructor. Missing initialization is suspected to cause crash. BUG=715826 Review-Url: https://codereview.chromium.org/2842373002 Cr-Commit-Position: refs/heads/master@{#467618} Committed: https://chromium.googlesource.com/chromium/src/+/68db6d36ffd81d907994065b71905d44875b3cc9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jinsuk Kim
3 years, 8 months ago (2017-04-26 23:43:47 UTC) #2
boliu
lgtm
3 years, 8 months ago (2017-04-26 23:46:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842373002/1
3 years, 7 months ago (2017-04-27 07:08:07 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 07:33:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/68db6d36ffd81d907994065b7190...

Powered by Google App Engine
This is Rietveld 408576698